[Bug 20144] New: Test suite is failing with new default SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Bug ID: 20144 Summary: Test suite is failing with new default SQL modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Blocks: 17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Test plan: Edit /etc/mysql/my.cnf (or equivalent), and add the following line to the mysqld block: sql-mode = "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION" Then restart mysql and execute the test suite. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See https://github.com/joubu/Koha/tree/bug_20144 for the patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 19492 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gale@rabbat.net --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 17860 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |CJSH@CJSHayward.com --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 18836 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Hi Jonathan, I just started to testing, found two issues till now: Can't recreate database, when creating table structure, I got: there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause I am on mysql 5.5.59, which is still default in jessie, more timestamp columns are possible from mysql 5.6.5: https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html Second one: Shouldn't be there atomic update for this change? https://github.com/joubu/Koha/commit/de14e25c7b03ca9a4812df627dec397eae4261a... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Few another ones: The tests t/db_dependent/www/batch.t and t/db_dependent/www/search_utf8.t are failing, probably because of this: When you try to open batch in manage marc import tool, you get: DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/Circulation/dateexpiry.t is failing with: Incorrect date value: '0000-00-00' for column 'dateexpiry' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20145 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #6)
Hi Jonathan, I just started to testing, found two issues till now:
Can't recreate database, when creating table structure, I got: there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause
I am on mysql 5.5.59, which is still default in jessie, more timestamp columns are possible from mysql 5.6.5: https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html
Erk, yes we should continue and support both. I have added a follow-up to default to NULL instead.
Second one: Shouldn't be there atomic update for this change? https://github.com/joubu/Koha/commit/de14e25c7b03ca9a4812df627dec397eae4261a...
Yep, commit amended. (In reply to Josef Moravec from comment #7)
Few another ones:
The tests t/db_dependent/www/batch.t and t/db_dependent/www/search_utf8.t are failing, probably because of this: When you try to open batch in manage marc import tool, you get: DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_kohadev.me.frameworktext' isn't in GROUP BY
I forgot the www tests! Fixed now.
t/db_dependent/Circulation/dateexpiry.t is failing with: Incorrect date value: '0000-00-00' for column 'dateexpiry'
Yes, see this commit: """ Bug 20144: [sql_modes] NOT FIXED - Incorrect date value: '0000-00-00' for column 'dateexpiry' See bug 20145. t/db_dependent/Circulation/dateexpiry.t """ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Thanks Jonathan, looks good for me now For signed-off patches see https://github.com/xmorave2/Koha/commits/bug_20144 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17328 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- The following commit: Bug 20144: [sql_modes] Fix output_pref with dateformat=iso makes another test to fail in t/DateUtils.t: # Failed test 'iso output 12hr' # at t/DateUtils.t line 47. # got: '2011-06-16 12:00' # expected: '2011-06-16 12:00 PM' # Looks like you failed 1 test of 67. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #10)
The following commit:
Bug 20144: [sql_modes] Fix output_pref with dateformat=iso
makes another test to fail in t/DateUtils.t:
# Failed test 'iso output 12hr' # at t/DateUtils.t line 47. # got: '2011-06-16 12:00' # expected: '2011-06-16 12:00 PM' # Looks like you failed 1 test of 67.
Confirmed. Setting to FQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- The git branch contains more than 60 commits (mostly independents from each other). Some commits are OK while others require more work. In order to not block the whole thing, I'm going to attach the patches that pass QA, and maybe open new reports for problematic patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71410&action=edit Bug 20144: [sql_modes] Fix borrowers table structure surname, address and city can be NULL Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71411&action=edit Bug 20144: [sql_modes] Set a default value for lowestPriority Fix for: Field 'lowestPriority' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71412&action=edit Bug 20144: [sql_modes] Fix default value for statistics.amount Must be an integer, not empty string Fix for: Data truncated for column 'value' Found with t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71413&action=edit Bug 20144: [sql_modes] Fix generated value for account_offsets.amount Fix error: Out of range value for column 'amount' DBD::mysql::st execute failed: Out of range value for column 'amount' at row 1 [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=7925469795795194609664.000000, 1='10', 2='Manual Debit'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. 7925469795795194609664.000000 => Should be lower anyway Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71414&action=edit Bug 20144: [sql_modes] Set default value for Aqbookseller in TestBuilder Fix for: Out of range value for column 'tax_rate' t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71415&action=edit Bug 20144: [sql_modes] Fix datatype for aqbasket.authorisedby It's defined as a VARCHAR(10) in DB, but it is expecting a borrowernumber instead Fix for Data too long for column 'authorisedby' Must be a FK but first a borrowernumber Need to update kohastructure for the comment? Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71416&action=edit Bug 20144: [sql_modes] Set default value for aqbasket.is_standing Fix for: Column 'is_standing' cannot be null t/db_dependent/Koha/Acquisition/Booksellers.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71417&action=edit Bug 20144: [sql_modes] Fix date format in tests Fix for: Incorrect date value: '01-01-2013' for column 'startdate' Incorrect date value: '01-01-2016' for column 'budget_period_enddate' Incorrect date value: '30-11-2013' for column 'enddate' Incorrect date value: '31-12-2015' for column 'budget_period_enddate' Incorrect date value: '12-31-2015' for column 'budget_period_enddate' Incorrect date value: '01-01-2014' for column 'entrydate' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71418&action=edit Bug 20144: [sql_modes] Set missinglist and recievedlist in subscriptionhistory Fix for: Field 'missinglist' doesn't have a default value t/db_dependent/Koha/Acquisition/Booksellers.t from mysql doc: BLOB, TEXT, GEOMETRY, and JSON columns cannot be assigned a default value. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71419&action=edit Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in tests Fix for: Field 'marcxml' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71420&action=edit Bug 20144: [sql_modes] Shorten cities.city_zipcode It's a varchar(20) Fix for: Data too long for column 'city_zipcode' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71421&action=edit Bug 20144: [sql_modes] Add default values for export_format columns Fix for: Field 'field_separator' doesn't have a default value Field 'encoding' doesn't have a default value field_separator and subfield_separator are only used for MARC csv profiles, no need to specify a default value Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71422&action=edit Bug 20144: [sql_modes] Correct quotes.timestamp values in tests Fix for: Incorrect datetime value: '0000-00-00 00:00:00' for column 'timestamp' t/db_dependent/Koha/GetDailyQuote.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71423&action=edit Bug 20144: [sql_modes] Shorten items.barcode It's a varchar(20) Fix for: Data too long for column 'barcode' t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71424&action=edit Bug 20144: [sql_modes] Add a value for borrower_attribute_types.description in tests Fix for: Field 'description' doesn't have a default value t/db_dependent/Koha/Patron/Attribute/Types.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71425&action=edit Bug 20144: [sql_modes] Fix default value for statistics.itemnumber Must be an integer, not empty string Fix for: Incorrect integer value: '' for column 'itemnumber' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71427&action=edit Bug 20144: [sql_modes] Set default value for Acccountline in TestBuilder Fix for: Data too long for column 'proccode' t/db_dependent/Accounts.t FIXME LATER - It's a varchar(4), must be integer! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71428&action=edit Bug 20144: [sql_modes] Shorten aqbudgets.budget_code Fix for: Data too long for column 'budget_code' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71429&action=edit Bug 20144: [sql_modes] Remove HAVING clause in GetLateOrders More attention needed here! Fix for: Non-grouping field 'quantity' is used in HAVING clause Having is useless, and certainly slower t/db_dependent/Acquisition.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71430&action=edit Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests Fix for: Field 'description' doesn't have a default value t/db_dependent/AdditionalField.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71431&action=edit Bug 20144: [sql_modes] Set issuingrules.no_auto_renewal_after to NULL in tests Fix for: Incorrect integer value: '' for column 'no_auto_renewal_after' FIXME - must we update values for existing installs? TODO - check if can be set to an empty string from the interface Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71432&action=edit Bug 20144: [sql_modes] Remove HAVING clause in GetUpcomingDueIssues More attention needed here! Fix for: Non-grouping field 'days_until_due' is used in HAVING clause t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #35 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71434&action=edit Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT Fix for: Field 'marcxml_old' doesn't have a default value t/db_dependent/ImportBatch.t Fixme - need to update existing DB? Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #36 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71435&action=edit Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests When created without Koha::Biblio. Fix for: Field 'datecreated' doesn't have a default value t/db_dependent/Items.t TODO LATER - Use Koha::Biblio instead Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71422|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71436&action=edit Bug 20144: [sql_modes] Correct quotes.timestamp values in tests Fix for: Incorrect datetime value: '0000-00-00 00:00:00' for column 'timestamp' t/db_dependent/Koha.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #38 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71437&action=edit Bug 20144: [sql_modes] Fix GROUP BY clause in GetLetters This subroutine is wrong and must be rewritten using Koha::Notice::Templates. Mainly because the DB structure is bad. Meanwhile we remove the branchcode from the SELECT to get correct results, it was not used by callers anyway. Fix for: 'koha_kohadev.letter.module' isn't in GROUP BY t/db_dependent/Letters.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71438&action=edit Bug 20144: [sql_modes] Set default value for marc_modification_template_actions Cannot be empty strings. Fix for: Data truncated for column 'conditional' Data truncated for column 'conditional_comparison' Incorrect integer value: '' for column 'conditional_regex' t/db_dependent/MarcModificationTemplates.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71440&action=edit Bug 20144: [sql_modes] Remove HAVING clause in GetBorrowersToExpunge Special attention needed here! Fix for: Non-grouping field 'currentissue' is used in HAVING clause t/db_dependent/Members.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71430|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71441&action=edit Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests Fix for: Field 'description' doesn't have a default value t/db_dependent/Serials.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71435|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71442&action=edit Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests Should call Koha::Biblio->new instead Fix for: Field 'datecreated' doesn't have a default value t/db_dependent/UsageStats.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71419|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71443&action=edit Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in tests Fix for: Field 'marcxml' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #44 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71444&action=edit Bug 20144: [sql_modes] Shorten auth_header.authtypecode values in tests Fix for: Data too long for column 'authtypecode' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #45 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71445&action=edit Bug 20144: [sql_modes] Set correct value for old_issues.issue_id in tests Fix for: Column 'issue_id' cannot be null Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #46 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71446&action=edit Bug 20144: [sql_modes] Shorten values for virtualshelfshares.invitekey in tests It's a varchar(10) Fix for: Data too long for column 'invitekey' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #47 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71447&action=edit Bug 20144: [sql_modes] Add default value for export_basket.description in tests Fix for: Field 'description' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #48 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71448&action=edit Bug 20144: [sql_modes] Fix GROUP BY clause in GetBasketsInfosByBookseller This need to be tested from the interface! Fix for: 'koha_kohadev.aqbasket.basketname' isn't in GROUP BY t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t We need this group by. We should not need to list all fields, from mysql 5.7 doc: https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html "The query is valid if name is a primary key of t or is a unique NOT NULL column. In such cases, MySQL recognizes that the selected column is functionally dependent on a grouping column. " However, MariaDB did not implemented yet: https://jira.mariadb.org/browse/MDEV-11588 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #49 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71449&action=edit Bug 20144: [sql_modes] Fix GROUP BY clause in GetInvoices Need to be tested from the interface! Fix for: 'koha_kohadev.aqinvoices.invoicenumber' isn't in GROUP BY Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #50 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71450&action=edit Bug 20144: [sql_modes] Set default value for Itemtype fees in TestBuilder Fix for: Out of range value for column 'amount' t/db_dependent/Circulation/Chargelostitem.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71451&action=edit Bug 20144: [sql_modes] Remove 'Null' string values from GetHardDueDate.t Must be undef or correct integer value Fix for: Incorrect integer value: 'Null' for column 'enrolmentperiod' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #52 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71452&action=edit Bug 20144: [sql_modes] Remove HAVING clause from GetTopIssues Fix for: 'koha_kohadev.b.title' isn't in GROUP BY t/db_dependent/Circulation/GetTopIssues.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #53 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71453&action=edit Bug 20144: [sql_modes] Set value for pending_offline_operations.timestamp Not null Fix for: Incorrect datetime value: 'null' for column 'timestamp' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71442|0 |1 is obsolete| | --- Comment #54 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71454&action=edit Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests Fix for: Field 'datecreated' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #55 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71455&action=edit Bug 20144: [sql_modes] Set value for creator_batches.timestamp Fix for: Incorrect datetime value: 'now()' for column 'timestamp' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #56 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71456&action=edit Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests Fix for: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #57 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71457&action=edit Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in GetItemsForInventory Fix for: DBD::mysql::st execute failed: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause [for Statement 'SELECT COUNT(*) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #58 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71458&action=edit Bug 20144: [sql_modes] Set default value for opac_news.content in tests Fix for: Field 'content' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #59 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71459&action=edit Bug 20144: [sql_modes] Fix values when creating a sql report in tests For fix: Data too long for column 'report_area' Incorrect integer value: 'null' for column 'cache_expiry' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #60 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71460&action=edit Bug 20144: [sql_modes] Fix search history tests Incorrect datetime value: '1374978877' for column 'time' Need to investigate this: Why did I put that value in the test? Does the feature correctly works? Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71441|0 |1 is obsolete| | --- Comment #61 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71461&action=edit Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests Fix for: Field 'description' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #62 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71462&action=edit Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to NULL if not passed Fix for: Incorrect integer value: '' for column 'numberlength' Incorrect integer value: '' for column 'weeklength' t/db_dependent/Serials/ReNewSubscription.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #63 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71463&action=edit Bug 20144: [sql_modes] Fix GROUP BY clause in Virtualshelves search (DT) Fix for: 'koha_kohadev.vs.shelfname' isn't in GROUP BY t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #64 from Julian Maurice <julian.maurice@biblibre.com> --- All attached patches are ready to be pushed. I will create other bug reports for the other patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20175 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20176 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #65 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71467&action=edit Bug 20144: [sql_modes] Do not store 0000-00-00 This patch needs to be linked with bug 20145. Fix for: Incorrect date value: '0000-00-00' for column 'dateexpiry' We cannot longer store 0000-00-00, but no need to. The tests must be kept for now as long as bug 20145 has a solution Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20177 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20178 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20179 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20180 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20182 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71419|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71422|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71430|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71435|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71441|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71442|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #67 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 71564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71564&action=edit Bug 20144: (follow-up) Adjust /patrons endpoint Fields 'address' and 'city' have been maybe nullable by this bug. This patch makes them nullable on the API as well. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail (randomly) when address or city are set to null by TestBuilder. - Apply this patch - Run: k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20178 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20199 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 [Bug 21355] GetDailyQuotes.t is fragile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30805 [Bug 30805] Missing default value on import_records.marxml_old -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org