https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20145 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #6)
Hi Jonathan, I just started to testing, found two issues till now:
Can't recreate database, when creating table structure, I got: there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause
I am on mysql 5.5.59, which is still default in jessie, more timestamp columns are possible from mysql 5.6.5: https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html
Erk, yes we should continue and support both. I have added a follow-up to default to NULL instead.
Second one: Shouldn't be there atomic update for this change? https://github.com/joubu/Koha/commit/de14e25c7b03ca9a4812df627dec397eae4261a...
Yep, commit amended. (In reply to Josef Moravec from comment #7)
Few another ones:
The tests t/db_dependent/www/batch.t and t/db_dependent/www/search_utf8.t are failing, probably because of this: When you try to open batch in manage marc import tool, you get: DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_kohadev.me.frameworktext' isn't in GROUP BY
I forgot the www tests! Fixed now.
t/db_dependent/Circulation/dateexpiry.t is failing with: Incorrect date value: '0000-00-00' for column 'dateexpiry'
Yes, see this commit: """ Bug 20144: [sql_modes] NOT FIXED - Incorrect date value: '0000-00-00' for column 'dateexpiry' See bug 20145. t/db_dependent/Circulation/dateexpiry.t """ -- You are receiving this mail because: You are watching all bug changes.