https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 193145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193145&action=edit Bug 41842: Improve translation of course reserves headings This patch adds some use of I18N functions to course reserves templates in order to improve the process of translation by adding context and placeholders. The patch also rewords some headings for clarity and consistency. To test, apply the patch and go to course reserves. - Add a course if necessary. - Click the course to view it. - On the course details page, confirm that the page title, breadcrumbs, and heading look correct. - Click "Edit" in the toolbar. - Check the page title, breadcrumbs, and heading again. - Return to the course details and click "Add reserves" and check that page. - Submit a barcode or biblionumber and check that page. - Test the "Batch add reserves" page. To test the improved I18N, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the modified strings, e.g. fr-FR-messages.po. - Locate strings pulled from course reserves templates for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:10 #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:42 #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:56 #, fuzzy, perl-brace-format msgid "Edit course {course_name}" msgstr "Modifier {course_name}" - Remove the "fuzzy," - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation:

perl translate install fr-FR

Switch to the translation you updated. Walk through the process of editing a course and adding course reserves to confirm that your translated strings show up. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Sponsorship status|--- |Sponsored Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199322&action=edit Bug 41842: Improve translation of course reserves headings This patch adds some use of I18N functions to course reserves templates in order to improve the process of translation by adding context and placeholders. The patch also rewords some headings for clarity and consistency. To test, apply the patch and go to course reserves. - Add a course if necessary. - Click the course to view it. - On the course details page, confirm that the page title, breadcrumbs, and heading look correct. - Click "Edit" in the toolbar. - Check the page title, breadcrumbs, and heading again. - Return to the course details and click "Add reserves" and check that page. - Submit a barcode or biblionumber and check that page. - Test the "Batch add reserves" page. To test the improved I18N, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the modified strings, e.g. fr-FR-messages.po. - Locate strings pulled from course reserves templates for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:10 #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:42 #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:56 #, fuzzy, perl-brace-format msgid "Edit course {course_name}" msgstr "Modifier {course_name}" - Remove the "fuzzy," - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation:

perl translate install fr-FR

Switch to the translation you updated. Walk through the process of editing a course and adding course reserves to confirm that your translated strings show up. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 [Bug 42099] Update course reserve pages to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- - <span>Edit [% course_name | html | $HtmlTags tag="em" %][%- IF course.section -%]- [% course.section | html | $HtmlTags tag="em" %][%- END -%]</span> + [% tx("Edit course {course_name}", { course_name = course_name }) | $raw %] Why did you remove the section from this one? Shouldn't it be + [% tx("Edit course {course_name}", { course_name = course_em }) | $raw %] like everywhere else? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42654 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|jonathan.druart@gmail.com |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200972&action=edit Bug 41842: Improve translation of course reserves headings This patch adds some use of I18N functions to course reserves templates in order to improve the process of translation by adding context and placeholders. The patch also rewords some headings for clarity and consistency. To test, apply the patch and go to course reserves. - Add a course if necessary. - Click the course to view it. - On the course details page, confirm that the page title, breadcrumbs, and heading look correct. - Click "Edit" in the toolbar. - Check the page title, breadcrumbs, and heading again. - Return to the course details and click "Add reserves" and check that page. - Submit a barcode or biblionumber and check that page. - Test the "Batch add reserves" page. To test the improved I18N, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the modified strings, e.g. fr-FR-messages.po. - Locate strings pulled from course reserves templates for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:10 #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:42 #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt:56 #, fuzzy, perl-brace-format msgid "Edit course {course_name}" msgstr "Modifier {course_name}" - Remove the "fuzzy," - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation:

perl translate install fr-FR

Switch to the translation you updated. Walk through the process of editing a course and adding course reserves to confirm that your translated strings show up. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Owen, can you confirm that adding spaces is ok for you? See also bug 42654. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200976&action=edit Bug 41842: Use space-dash-space separator between course name and section The staff interface templates were using a bare hyphen with no spaces when displaying course name and section together, while the OPAC templates (Bug 42654) use ' - ' (space-dash-space). This brings the staff interface into alignment with the OPAC convention for consistency and readability. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #12 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys, I believe we need the same fix the 3rd patch is doing for course-reserves.tt to the remaining .tt files in the patchset: 1) Run: prove xt/tt_tidy.t 2) 5 tests fail: Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt should be kept tidy' Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt should be kept tidy' Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_add_items.tt should be kept tidy' Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt should be kept tidy' Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt should be kept tidy' 3) Note course-reserves.tt is NOT in the failure list. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203285&action=edit Bug 41842: (follow-up) Ensure that tidy doesn't trim wanted whitespace Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.