[Bug 43163] New: Booking tests fail Test::NoWarnings since Bug 42391 restored DB exception warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 Bug ID: 43163 Summary: Booking tests fail Test::NoWarnings since Bug 42391 restored DB exception warnings Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- The follow-up on Bug 42391 restored the DB exception warnings in Koha::Object::store, but the earlier test refactor on that bug had already removed the warning_like wrappers from the booking tests. On current main, t/db_dependent/Koha/Booking.t and t/db_dependent/api/v1/bookings.t both fail 'no warnings': - Booking.t: duplicate booking_id store (DuplicateID) and invalid status enum update (BadValue) - api/v1/bookings.t: POST with an existing booking_id (409) This patch wraps the three sites in warning_like, following the pattern the Bug 42391 follow-up used in Object.t. To test: 1. prove t/db_dependent/Koha/Booking.t t/db_dependent/api/v1/bookings.t -> both fail 'no warnings' on main 2. Apply the patch, repeat → both pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 202479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202479&action=edit Bug 43163: Silence expected DB exception warnings in booking tests Bug 42391 restored the DB exception warnings in Koha::Object::store, but the booking tests exercising those failure paths were left without warning_like wrappers, so Test::NoWarnings fails on both files. - Koha/Booking.t: wrap the duplicate booking_id store (DuplicateID) and the invalid status enum update (BadValue) - api/v1/bookings.t: wrap the POST with an existing booking_id (409) Test plan: 1. prove t/db_dependent/Koha/Booking.t t/db_dependent/api/v1/bookings.t fails on main with 'no warnings' before the patch, passes after Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41898 [Bug 41898] Expired bookings do not display when expired filter is used in patron record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 202562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202562&action=edit Bug 43163: Silence expected DB exception warnings in booking tests Bug 42391 restored the DB exception warnings in Koha::Object::store, but the booking tests exercising those failure paths were left without warning_like wrappers, so Test::NoWarnings fails on both files. - Koha/Booking.t: wrap the duplicate booking_id store (DuplicateID) and the invalid status enum update (BadValue) - api/v1/bookings.t: wrap the POST with an existing booking_id (409) Test plan: 1. prove t/db_dependent/Koha/Booking.t t/db_dependent/api/v1/bookings.t fails on main with 'no warnings' before the patch, passes after Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43163 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |tomascohen@gmail.com Status|Signed Off |RESOLVED --- Comment #3 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi Paul, I'm fairly certain these changes are already included in the last follow-up in bug 42391. I'm pushing that today. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org