[Bug 20360] New: Auto-Renew notices send in advance of No Renewal Before period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Bug ID: 20360 Summary: Auto-Renew notices send in advance of No Renewal Before period Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Koha sends auto-renew notices for failed renewals before the period defined by the No Renewal Before value in the circulation rule. This results in a confusing and premature notice. To replicate: 1: Set up a circulation rule that makes the item due more than 2 days in the future, allows auto-renewals, and has a No Renewal Before value of 1 2: Check out an item corresponding to the circ rule created 3: Run the auto-renew cron. The item will not renew and no notice will be generated because the issues table shows it is too soon to perform an auto-renew. 4: Plase a hold on the item for another patron 5: Run the auto-renew cron again. A notice will be generated that the item could not be renewed because there is a hold, even though the item due date is still multiple days off, meaning the item is outside of the No Renewal Before period -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 --- Comment #1 from Andrew <andrew@bywatersolutions.com> --- An auto-renewal notice is sent out if issues.auto_renew_error shows a new value other than "too soon." Values such as "too many" or "reserve" take precedence over "too soon." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Jess Tobin <lara005@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lara005@gmail.com --- Comment #2 from Jess Tobin <lara005@gmail.com> --- This really is a problematic bug. Our patrons are used to seeing a notice telling them that they've reached the max number of renewals...once they've reached that limit, not the day after their final successful renewal. It's also an issue for us with holds--Patron A will receive a failed renewal notice the day after Patron B places a hold on a book checked out to Patron A, regardless of how many days remain before the actual due date of book for Patron A. We're a small library; I can only imagine the confusion that would result for patrons at a large public library, for example. Many thanks in advance to anyone who is able to put some effort toward fixing this bug!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19014 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please take a look at bug 19014, I think it fixes the issue you face. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com | |, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #3)
Please take a look at bug 19014, I think it fixes the issue you face.
Happy to get more people looking at bug 19014. "It's also an issue for us with holds--Patron A will receive a failed renewal notice the day after Patron B places a hold on a book checked out to Patron A, regardless of how many days remain before the actual due date of book for Patron A." I've been hearing about this one a lot and would love to find a solution to it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22333 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I think I have a solution and I'll be -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- I have a solution which will live in the automatic_renewals.pl script. It'll essentially borrow the code from #22333 but put it into automatic_renewals.pl wrapped with a system preference so that the first thing automatic_renewals.pl does is check if it's too early to renew (ie consult No Renewal Before or fallback to checking if it's before the due date). I think this should be a good solution. Just trialing it locally first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen@ub.lu.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 --- Comment #7 from Björn Nylén <bjorn.nylen@ub.lu.se> --- (In reply to David Cook from comment #6)
I have a solution which will live in the automatic_renewals.pl script.
It'll essentially borrow the code from #22333 but put it into automatic_renewals.pl wrapped with a system preference so that the first thing automatic_renewals.pl does is check if it's too early to renew (ie consult No Renewal Before or fallback to checking if it's before the due date).
I think this should be a good solution.
Just trialing it locally first.
Hi David! This is how we would like it to work too. (We = Lund university :) ) We'd be happy to test your patch when you think it's ready! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk --- Comment #8 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Almost 3 years after going live with auto-renewals, including our workaround to deal with bug 19014 we have this very day found that the RenewalPeriodBase was set wrongly (left set the "current date", which was sensible for a manual renewal environment, but is I think NOT sensible for an auto-renewal one). This variable has had an impact on renewal timings and renewal outcomes. Our calendar has Sa/Su as closed days, items being 7 day loans, the No Renewal Before set to 1, and auto-renewal running at 10pm Mo-Su. These variables coupled with the wrong RenewalBasePeriod has seen the loan period on renewal drop a day, until the Monday is reached and then the Sunday closure is seen and items renew every Monday for 7 days from then on. So many variables interact with auto-renewal functionality it is challenging to get then all "right". We are about to look at 18.11 to see how many bug fixes have made it there, up from our 17.05 version (especially bug 19014). But if unexpected timing puzzles are happening, it might be worthwhile checking the RenewalBasePeriod setting to see if it is set correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Letting folks know that I have a patch for this issue at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 19014 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org