[Bug 22884] New: remove some punctuation on xslt templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Bug ID: 22884 Summary: remove some punctuation on xslt templates Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: hagud@orex.es QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Checing marc21 loc rules I have seen some issues with out xslt templates 1. Fields 020 and 022 should not inclue ending '.' 2. Field 300 should not include '.' if 300$c is cm or mm On the other hand I am not sure if there is a rule on 100$e to be published between [relator] thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|remove some punctuation on |Remove some punctuation on |xslt templates |xslt templates CC| |katrin.fischer@bsz-bw.de Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove some punctuation on |Remove ending . from XSLT |xslt templates |templates --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the end user doesn't need the . and it is more irritating then helpful, especially since we are very inconsistent in printing it. I think either we rely on libraries adding the punctuation or let Koha add it, but mixing both is not good. I suggest to remove the . where we are currently displaying it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89624&action=edit Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Status|Needs Signoff |Failed QA --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- It seems silly to fail QA for one full stop, but.... This patch appears to work for all the MARC fields listed in comment 2 on the Intranet, but on the OPAC there is a full stop on the Series section (440) after 'Name of part/section of a work' (not sure if that's because it's the last value listed or because of that particular field). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90702&action=edit Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hayley, thx for testing so well! It appears it was fixed in staff, but I forgot to remove it in OPAC. Could you have another look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89624|0 |1 is obsolete| | --- Comment #6 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90760&action=edit Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90702|0 |1 is obsolete| | --- Comment #7 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90761&action=edit Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Claudio <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com --- Comment #8 from Claudio <costalc@gmail.com> --- A little contribution: Tag 440 is obsolete in MARC21. It should be replaced by tag 490 as the default "series statement fields" in a fresh installation. See: http://www.loc.gov/marc/bibliographic/bd4xx.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Hayley! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #9)
Thank you, Hayley!
No prob Katrin :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 frederik.chenier@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90760|0 |1 is obsolete| | --- Comment #11 from frederik.chenier@inlibro.com --- Created attachment 90927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90927&action=edit Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 frederik.chenier@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90761|0 |1 is obsolete| | --- Comment #12 from frederik.chenier@inlibro.com --- Created attachment 90928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90928&action=edit Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- After these patches if you have a 440 and a 490 in the record they have no space between. I mean, you probably shouldn't have both, but I have seen stranger things -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, this is a tricky one... I'll have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we keep the . separator or would some other thing like ; look nicer? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92143&action=edit Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #13)
After these patches if you have a 440 and a 490 in the record they have no space between.
I mean, you probably shouldn't have both, but I have seen stranger things
Follow-up added, thx for testing Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92143|0 |1 is obsolete| | --- Comment #18 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92203&action=edit Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90927|0 |1 is obsolete| | --- Comment #19 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92204&action=edit Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90928|0 |1 is obsolete| | --- Comment #20 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92205&action=edit Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92203|0 |1 is obsolete| | --- Comment #21 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92206&action=edit Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92204|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93559&action=edit Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92205|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93560&action=edit Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92206|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93561&action=edit Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove ending . from XSLT |Remove ending . from XSLT |templates |detail templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24320 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org