[Bug 11850] New: Bulkmarcimport does not append in logfile
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Bug ID: 11850 Summary: Bulkmarcimport does not append in logfile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org Bulkmarcimport has the -l option, which allows to write to a logfile. It does work, however, its behavior is not what we expect from a logfile. Indeed, bulkmarcimport erases the logfile each time it is executed. The expected behavior imho is to append the logs to the given file. Test plan: 1) use bulkmarcimport several times with the same logfile given with -l. 2) the logfile is erased every time. -> KO Apply the patch, then: 1) use bulkmarcimport several times with the same logfile given with -l. 2) the logs are correctly appended to the logfile. -> OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 25666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25666&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #2 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Some concerns have been raised on #koha whether new content for a log file should erase previous content or add to it. In my opinion, it should add, to prevent data loss. Managing growing files should be a sysop concern (by using logrotate, for instance). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25961&action=edit Bug 11850: Fix bulkmarcimport -l option to append to the logfile Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> ---
From a QA standpoint, if this is controversial, maybe there should be a flag to choose between append vs overwrite for file logging.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this can't go in as it is. On #koha an optional flag was discussed: http://irc.koha-community.org/koha/2014-02-26#i_1471750 Setting to "In Discussion". I am tending to make this new behaviour depending on a command line option. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25666|0 |1 is obsolete| | Attachment #25961|0 |1 is obsolete| | --- Comment #6 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 26022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26022&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #7 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- The new proposed patch adds a -append option to add to the logfile. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 --- Comment #8 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 26313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26313&action=edit Bug 11850: Adds a -append option to add data to the logfile Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Keeps current behaviour as default. The -append option is described in the POD and works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26022|0 |1 is obsolete| | Attachment #26313|0 |1 is obsolete| | --- Comment #9 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 26314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26314&action=edit Bug 11850: [SIGNED-OFF] Adds a -append option to add data to the logfile Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Keeps current behaviour as default. The -append option is described in the POD and works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26314|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26846&action=edit [PASSED QA] Bug 11850: [SIGNED-OFF] Adds a -append option to add data to the logfile Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Keeps current behaviour as default. The -append option is described in the POD and works as expected. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Adding a date/time to the output might be good, to make it easier to find the entry you were looking for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Matthias! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org