[Bug 11570] New: Upgrade jQueryUI to latest version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Bug ID: 11570 Summary: Upgrade jQueryUI to latest version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Koha master currently uses jQueryUI version 1.8.23. We should upgrade to the latest version, currently 1.10.3. This upgrade would not conflict with our version of jQuery. At the very least the upgrade would help with Bug 11042 because of improvements to the default jQueryUI CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrade jQueryUI to latest |Upgrade jQueryUI to latest |version |version in the staff client --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I'm revising the scope of this bug to cover the staff client only. A separate bug should cover the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24465&action=edit Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.3. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes: background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25861&action=edit Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.4. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes (hash mark escaped so that it will appear in commit msg): \#header_search ul.ui-tabs-nav li.ui-tabs-active { background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25861|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25960&action=edit Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.4. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes (hash mark escaped so that it will appear in commit msg): \#header_search ul.ui-tabs-nav li.ui-tabs-active { background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I am having difficulties testing the overdues report - I don't have a filter for patron attributes showing up. The pref is enabled and the user showing up in the report has patron attributes linked to authorized values set. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
Hi Owen,
I am having difficulties testing the overdues report - I don't have a filter for patron attributes showing up. The pref is enabled and the user showing up in the report has patron attributes linked to authorized values set.
- In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values.
Do you have the "Searchable" flag set for this patron attribute? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, thanks - I think that was the problem. If you want to take a look here, please do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: All work as expected, no regression found. I just found 2 small differences: 1/ on the patron headers, 1px alignment change: The text "Check out", "Check in", "Search the catalog" in tabs were 1px higher than with the patch (take a magnifying glass to see the difference! :)) 2/ The accordion has now a border on bottom of the title. See screenshots. In my opinion, it is not blocker. That could be fix later if needed. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25960|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26628&action=edit Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.4. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes (hash mark escaped so that it will appear in commit msg): \#header_search ul.ui-tabs-nav li.ui-tabs-active { background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26629&action=edit with path -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26630&action=edit without patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11042 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12094 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11570 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org