[Bug 8422] New: Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 Priority: P5 - low Change sponsored?: --- Bug ID: 8422 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block Severity: minor Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Currently, circulation.pl states: "Patron has x overdue item(s). Check out anyway?" when syspref OverduesBlockCirc is set to "Ask for confirmation" or "Block". Since checkout is completely blocked, it shouldn't ask that question. Instead, it should say "Checkouts are BLOCKED because patron has overdue items". --- On a side note, this bug reveals inconsistencies in how blocked checkouts are handled. Even when OverduesBlockCirc is set to Block, the barcode input still appears. It's only when one hits checkout that the checkout is prevented and the warning message appears. However, when the patron surpasses the fine/charge limit specified in syspref "noissuescharge", the barcode input doesn't appear at all. Instead, a message appears that says "Cannot check out!" I think that this would be a much better behaviour when checkouts are blocked for all other reasons besides exceeding fine limits. That said, this template is still not great. It says: "Cannot check out! Overdues: Patron has ITEMS OVERDUE. See highlighted items below Fees & Charges: Patron has Outstanding fees & charges of 10.00. Checkouts are BLOCKED because fine balance is OVER THE LIMIT. Make Payment" These are the "Attention" messages. They should still appear on the right side of the screen under "Attention". The only thing that should appear in the centre is "Checkouts are BLOCKED because fine balance is OVER THE LIMIT. Make Payment". The current template is misleading. Even though the message does say explicitly that checkouts are blocked due to the fines, it SEEMS that checkouts are blocked due to "Overdues, Fees & Charges" based on the visual layout. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 10779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10779&action=edit Bug 8422: Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 kyle.m.hall@gmail.com <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10779|0 |1 is obsolete| | --- Comment #2 from kyle.m.hall@gmail.com <kyle@bywatersolutions.com> --- Created attachment 10829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10829&action=edit [SIGNED-OFF] Bug 8422 - Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block Previously, the message Patron has x overdue item(s). Checkout anyway? was shown when syspref OverduesBlockCirc was set to Ask for confirmation or Block. This patch changes the message for Block to: Checkouts are BLOCKED because patron has overdues. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 kyle.m.hall@gmail.com <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 10829 [details] [SIGNED-OFF] Bug 8422 - Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block
Previously, the message Patron has x overdue item(s). Checkout anyway? was shown when syspref OverduesBlockCirc was set to Ask for confirmation or Block.
This patch changes the message for Block to: Checkouts are BLOCKED because patron has overdues.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
passing QA... trivial patch passes QA tests OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> ---
Thoughts?
David, my thoughts are that the Circulation would not deserve a complete rewritte... Many things are crappy/ years of code piled, you've found one. About your patch = it's pushed. Note that you could have kept the [% USERBLOCKEDOVERDUE %] information: Checkouts are BLOCKED because patron has [% USERBLOCKEDOVERDUE %] overdue items Is there reason not to do it that way ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #4)
Thoughts?
David, my thoughts are that the Circulation would not deserve a complete rewritte... Many things are crappy/ years of code piled, you've found one.
About your patch = it's pushed. Note that you could have kept the [% USERBLOCKEDOVERDUE %] information: Checkouts are BLOCKED because patron has [% USERBLOCKEDOVERDUE %] overdue items
Is there reason not to do it that way ?
Point well received, Paul. I'm not sure that the template would need a complete re-write, but I figured it was worth flagging and maybe I will come back and fix that up someday. I don't have the programming skill (yet) to work on some of the deeper issues, but I figure that I can help iron out the interface. As for my patch, I thought about keeping the [%
USERBLOCKEDOVERDUE %] information, but I thought that it was potentially misleading. The patron isn't blocked because of the number of overdue items. They're blocked because they have overdue items. I figured that my patch used more precise language.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org