http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422 Priority: P5 - low Change sponsored?: --- Bug ID: 8422 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block Severity: minor Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Currently, circulation.pl states: "Patron has x overdue item(s). Check out anyway?" when syspref OverduesBlockCirc is set to "Ask for confirmation" or "Block". Since checkout is completely blocked, it shouldn't ask that question. Instead, it should say "Checkouts are BLOCKED because patron has overdue items". --- On a side note, this bug reveals inconsistencies in how blocked checkouts are handled. Even when OverduesBlockCirc is set to Block, the barcode input still appears. It's only when one hits checkout that the checkout is prevented and the warning message appears. However, when the patron surpasses the fine/charge limit specified in syspref "noissuescharge", the barcode input doesn't appear at all. Instead, a message appears that says "Cannot check out!" I think that this would be a much better behaviour when checkouts are blocked for all other reasons besides exceeding fine limits. That said, this template is still not great. It says: "Cannot check out! Overdues: Patron has ITEMS OVERDUE. See highlighted items below Fees & Charges: Patron has Outstanding fees & charges of 10.00. Checkouts are BLOCKED because fine balance is OVER THE LIMIT. Make Payment" These are the "Attention" messages. They should still appear on the right side of the screen under "Attention". The only thing that should appear in the centre is "Checkouts are BLOCKED because fine balance is OVER THE LIMIT. Make Payment". The current template is misleading. Even though the message does say explicitly that checkouts are blocked due to the fines, it SEEMS that checkouts are blocked due to "Overdues, Fees & Charges" based on the visual layout. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.