[Bug 43198] New: Update suggestions template to use grid layout for forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 Bug ID: 43198 Summary: Update suggestions template to use grid layout for forms Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 39780 Target Milestone: --- This patch will update the suggestions template to use grid layout for the add/edit form. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39780 [Bug 39780] Update library groups form to use grid layout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Small patch Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202698&action=edit Bug 43198: Update suggestions template to use grid layout for forms This patch updates the suggestions template in the staff client so that the add/entry form uses grid layout. The patch also does some JavaScript updates to disconnect the showing/hiding of suggestion reasons from markup structure. To test, apply the patch and go to Suggestions. - Click "New purchase suggestion." - The update to the "Bibliographic information" section is straightforward. - In the "Suggestion management" section I've broken the form fields out of the layout table and put them in a standard structure with descriptive labels. - Confirm that the "Select patron" and "Select manager" process works correctly. - I moved the "Notify manager" hint out of the checkbox title attribute and into a standard hint. - Save your suggestion and then open it for editing. - In the "Suggestion management" section you should now see fields for "Status" and "Reason." - Choosing "Other reason" as a reason should hide the "Reason" dropdown and display a "Other reason" field. - Clicking "Cancel" should hide the "Other reason" line and redisplay the reason dropdown, resetting the selection to "Choose a reason." - Go the main suggestions page with the list of suggestions. - Check the checkbox for one or more suggestions - Below the list of suggestions in the "Change selected suggestions" section, test the "Reason" dropdown just like you did from the edit page. It should work correctly. NOTE: manageable-mixin.inc has been updated with new form grid markup. This include is also used by the template ill/ill-requests.tt for editing an ILL request. I didn't modify that template for simplicity's sake and the layout of that form is not disrupted. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |maxeinergl@gcc.edu --- Comment #2 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- I encountered a couple of issues with these updates. - In the new and edit forms, the “Last modification on:” element has been lost from the Suggestion management section. It frankly didn’t make sense on the new suggestion form, but I think it would still be wanted on the edit form. - In the Acquisition information section of the new and edit forms, the Fund element with its dropdown and checkbox for “Show inactive” is missing. - In the new form, the “Select patron” button disappears once a patron is selected, meaning you cannot go back if you selected the wrong person without either canceling the suggestion or saving/editing. I think the button should remain present as it did before patch, which also matches the action of the Select manager button. I’m a bit uncomfortable losing the grid layout in Suggestion management. The original is so easy to consult at a quick glance. We don’t use this page much but it appears an intentional design. Perhaps someone who works with this page regularly could advise how important it is to their workflow. There is a typo in the Notify manager hint (also present in the original). : “A NOTIFY_MANAGER notice will be generated and send to the manager...” should be “sent”. Functionally, everything in the test plan worked correctly. I like the text change of the button from “Set to patron” to “Select patron” which matches elsewhere. I also like the text change of “Others” to “Other reason” in the Reason dropdown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202698|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206908&action=edit Bug 43198: Update suggestions template to use grid layout for forms This patch updates the suggestions template in the staff client so that the add/entry form uses grid layout. The patch also does some JavaScript updates to disconnect the showing/hiding of suggestion reasons from markup structure. To test, apply the patch and go to Suggestions. - Click "New purchase suggestion." - The update to the "Bibliographic information" section is straightforward. - In the "Suggestion management" section I've broken the form fields out of the layout table and put them in a standard structure with descriptive labels. - Confirm that the "Select patron" and "Select manager" process works correctly. - I moved the "Notify manager" hint out of the checkbox title attribute and into a standard hint. - Save your suggestion and then open it for editing. - In the "Suggestion management" section you should now see fields for "Status" and "Reason." - Choosing "Other reason" as a reason should hide the "Reason" dropdown and display a "Other reason" field. - Clicking "Cancel" should hide the "Other reason" line and redisplay the reason dropdown, resetting the selection to "Choose a reason." - Go the main suggestions page with the list of suggestions. - Check the checkbox for one or more suggestions - Below the list of suggestions in the "Change selected suggestions" section, test the "Reason" dropdown just like you did from the edit page. It should work correctly. NOTE: manageable-mixin.inc has been updated with new form grid markup. This include is also used by the template ill/ill-requests.tt for editing an ILL request. I didn't modify that template for simplicity's sake and the layout of that form is not disrupted. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Gretchen Maxeiner from comment #2)
I’m a bit uncomfortable losing the grid layout in Suggestion management.
Just to keep things clear since there's more than one kind of grid being talked about here, in this case "grid layout" is referring to the way the data was previously presented in an HTML table. I also am not a frequent user of suggestions so I shouldn't be the final authority, but my update makes the page consistent with the way we present this kind of information everywhere else. There are very few remaining cases where we present entry form options in a table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org