https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43198 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202698&action=edit Bug 43198: Update suggestions template to use grid layout for forms This patch updates the suggestions template in the staff client so that the add/entry form uses grid layout. The patch also does some JavaScript updates to disconnect the showing/hiding of suggestion reasons from markup structure. To test, apply the patch and go to Suggestions. - Click "New purchase suggestion." - The update to the "Bibliographic information" section is straightforward. - In the "Suggestion management" section I've broken the form fields out of the layout table and put them in a standard structure with descriptive labels. - Confirm that the "Select patron" and "Select manager" process works correctly. - I moved the "Notify manager" hint out of the checkbox title attribute and into a standard hint. - Save your suggestion and then open it for editing. - In the "Suggestion management" section you should now see fields for "Status" and "Reason." - Choosing "Other reason" as a reason should hide the "Reason" dropdown and display a "Other reason" field. - Clicking "Cancel" should hide the "Other reason" line and redisplay the reason dropdown, resetting the selection to "Choose a reason." - Go the main suggestions page with the list of suggestions. - Check the checkbox for one or more suggestions - Below the list of suggestions in the "Change selected suggestions" section, test the "Reason" dropdown just like you did from the edit page. It should work correctly. NOTE: manageable-mixin.inc has been updated with new form grid markup. This include is also used by the template ill/ill-requests.tt for editing an ILL request. I didn't modify that template for simplicity's sake and the layout of that form is not disrupted. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.