https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66064&action=edit Bug 19126: Fix Members.t with IndependentBranches set If you enabled that pref, Members.t fails with: t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63. The first one is: t/db_dependent/Members.t .. 32/63 Failed test 'Staff patron not deleted from list' at t/db_dependent/Members.t line 304. Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the state of this preference. Trivially fixing it here by disabling the pref before the first call. Test plan: [1] Do not apply this patch yet. Enable IndependentBranches. [2] Run Members.t and observe that it fails. [3] Apply this patch. And run Members.t again. It should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66064|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66259&action=edit [SIGNED-OFF] Bug 19126: Fix Members.t with IndependentBranches set If you enabled that pref, Members.t fails with: t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63. The first one is: t/db_dependent/Members.t .. 32/63 Failed test 'Staff patron not deleted from list' at t/db_dependent/Members.t line 304. Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the state of this preference. Trivially fixing it here by disabling the pref before the first call. Test plan: [1] Do not apply this patch yet. Enable IndependentBranches. [2] Run Members.t and observe that it fails. [3] Apply this patch. And run Members.t again. It should pass now. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66259|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66484&action=edit Bug 19126: Fix Members.t with IndependentBranches set If you enabled that pref, Members.t fails with: t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63. The first one is: t/db_dependent/Members.t .. 32/63 Failed test 'Staff patron not deleted from list' at t/db_dependent/Members.t line 304. Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the state of this preference. Trivially fixing it here by disabling the pref before the first call. Test plan: [1] Do not apply this patch yet. Enable IndependentBranches. [2] Run Members.t and observe that it fails. [3] Apply this patch. And run Members.t again. It should pass now. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.