https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 66029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66029&action=edit Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar Test 1. Hit the page /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx xx is a booksellerid 2. Apply the patch and reload the page. 3. You can see vendor name in browser title bar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- This does fix the title bar. Though I was thinking of formatting. Should it be Vendor {name} without any punctuation? Perhaps it should have a colon or something, because Vendor is not part of the name, but the section we're in. Perhaps the › thing like Between Koha and Vendor? I'll sign off as is, and let QA comment further on that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66029|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 66034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66034&action=edit [SIGNED-OFF] Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar Test 1. Hit the page /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx xx is a booksellerid 2. Apply the patch and reload the page. 3. You can see vendor name in browser title bar. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #3)

This does fix the title bar. Though I was thinking of formatting. Should it be Vendor {name} without any punctuation? Perhaps it should have a colon or something, because Vendor is not part of the name, but the section we're in. Perhaps the › thing like Between Koha and Vendor? I'll sign off as is, and let QA comment further on that.

It follows the existing pattern. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66034|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66485&action=edit Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar Test 1. Hit the page /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx xx is a booksellerid 2. Apply the patch and reload the page. 3. You can see vendor name in browser title bar. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.