[Bug 12754] New: Add XSLT action to MARC modification templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 Bug ID: 12754 Summary: Add XSLT action to MARC modification templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30754&action=edit Bug 12754: Add XSLT action to MARC modification templates This is the dbrev for this report. It adds enum run_xslt for the action column. It adds a new columns run_xslt for the XSLT file to run. Test plan: Upgrade via the webinstaller and check table marc_modification_template_actions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30754|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30756&action=edit Bug 12754: Add XSLT action to MARC modification templates This is the dbrev for this report. It adds enum run_xslt for the action column. It adds a new columns run_xslt for the XSLT file to run. Test plan: Upgrade via the webinstaller and check table marc_modification_template_actions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30757&action=edit Bug 12754: [TESTING ONLY] dbix update for actions table This patch should not be pushed. The RM will update the DBIx schema. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30758&action=edit Bug 12754: Add run_xslt to MarcModificationTemplates.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30759&action=edit Bug 12754: Template changes for run_xslt in marc mod templates Adds action Run XSLT to the admin template and script. Test plan: Add, edit and delete actions with/without xslt actions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Still one patch forthcoming that performs the actual xslt action.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30759|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30782&action=edit Bug 12754: Template changes for run_xslt in marc mod templates Adds action 'Run XSLT' to the admin template and script. Test plan: Go to Manage MARC modification templates. Select a template. Add, edit and delete actions, including the Run XSLT type. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30783&action=edit Bug 12754: Perform the actual XSLT action for marc mod template This patch modifies MarcModificationTemplates.pm. A local subroutine _RunXSLTAction is added to perform the actual xslt transformation using the XSLTHandler object. Test plan: Add some XSLT actions to a marc mod template. Run Stage for Import and select the correct marc mod template. Check your staged records for the expected changes (you can also view these reservoir records in Cataloging search). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30784&action=edit Bug 12754: [TESTING ONLY] Sample XSLT file for testing This test XSLT adds a 500 tag to your record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Very promising! I have a few suggestions before I would sign it off though: 1) Change the database column name from "run_xslt" to just "xslt". To me "run_xslt" sounds like a boolean, and could cause confusion for future developers. 2) Change the phrase "Run XSLT" to "Apply XSLT", which is a more proper way to describe this in English. 3) The form input for the XSLT code should be a textarea, rather than a single line text input. 4) Please add a formal step by step test plan With those changes, I think this will make an excellent addition for the modification templates! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks like you did add a test plan, I just missed it, so you can scratch point 4! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #10)
Very promising! I have a few suggestions before I would sign it off though: 1) Change the database column name from "run_xslt" to just "xslt". To me "run_xslt" sounds like a boolean, and could cause confusion for future developers. 2) Change the phrase "Run XSLT" to "Apply XSLT", which is a more proper way to describe this in English. 3) The form input for the XSLT code should be a textarea, rather than a single line text input. 4) Please add a formal step by step test plan
With those changes, I think this will make an excellent addition for the modification templates!
Will do that. About point 3: The single line of text refers to a filename instead of the actual xslt code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. de Rooy from comment #12)
(In reply to Kyle M Hall from comment #10)
Very promising! I have a few suggestions before I would sign it off though: 1) Change the database column name from "run_xslt" to just "xslt". To me "run_xslt" sounds like a boolean, and could cause confusion for future developers. 2) Change the phrase "Run XSLT" to "Apply XSLT", which is a more proper way to describe this in English. 3) The form input for the XSLT code should be a textarea, rather than a single line text input. 4) Please add a formal step by step test plan
With those changes, I think this will make an excellent addition for the modification templates!
Will do that. About point 3: The single line of text refers to a filename instead of the actual xslt code.
Is this a reference to a file on the server? Would it not be easier to store the code in the database so it can be viewed and edited from the template editor? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #13)
Is this a reference to a file on the server? Would it not be easier to store the code in the database so it can be viewed and edited from the template editor?
Yes, it refers to a file. But we could offer both approaches.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. de Rooy from comment #14)
(In reply to Kyle M Hall from comment #13)
Is this a reference to a file on the server? Would it not be easier to store the code in the database so it can be viewed and edited from the template editor?
Yes, it refers to a file. But we could offer both approaches..
I think that would be for the best! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Status back to Assigned. Will send some changes soon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12973 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12973 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org