[Bug 33077] New: Improve ease of translating template title tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Bug ID: 33077 Summary: Improve ease of translating template title tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 15395 Title tags (<title>) in templates present an especially difficult case for translators because we can't use our usual trick of wrapping text elements with <span>. This results in strings like this waiting for translation: #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6 #, c-format msgid "" "%s %s Modify city %s New city %s › %s %s Confirm deletion of city " "› %s %s Cities › Administration › Koha " We can instead use the i18n template plugin introduced by Bug 15395 to wrap individual title tag elements like so: [% t("Modify city") | html %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 [Bug 15395] Internationalization: plural forms, context, and more -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147465&action=edit Bug 33077: Improve ease of translating template title tags This patch uses the cities administration page as a proof-of-concept for using the [% t() %] construction to wrap translatable string in template <title> tags. This should result in a significant improvement in translatability. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po you should no longer see a reference to cities.tt line 6, "#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6" - In fr-FR-messages.po you should see several strings which have been pulled individually from the <title> tag: - cities.tt:9, msgid "Modify city" - cities.tt:11, msgid "New city" - cities.tt:15, msgid "Confirm deletion of city" - cities.tt:19, msgid "Administration", msgid "Cities", msgid "Koha", and msgid "Administration" Translate the strings in fr-FR-messages.po and install the updated translation: perl misc/translator/translate install fr-FR Swith to the update language in the staff interface and confirm that the Cities page title is translated correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147465|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 147794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147794&action=edit Bug 33077: Improve ease of translating template title tags This patch uses the cities administration page as a proof-of-concept for using the [% t() %] construction to wrap translatable string in template <title> tags. This should result in a significant improvement in translatability. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po you should no longer see a reference to cities.tt line 6, "#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6" - In fr-FR-messages.po you should see several strings which have been pulled individually from the <title> tag: - cities.tt:9, msgid "Modify city" - cities.tt:11, msgid "New city" - cities.tt:15, msgid "Confirm deletion of city" - cities.tt:19, msgid "Administration", msgid "Cities", msgid "Koha", and msgid "Administration" Translate the strings in fr-FR-messages.po and install the updated translation: perl misc/translator/translate install fr-FR Swith to the update language in the staff interface and confirm that the Cities page title is translated correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Sorry for my confusion! It works well for cities! Will this also work with titles with variables in them? For example on moremember.pl the title is "Patron details for name (cardnumber)..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147794|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149333&action=edit Bug 33077: Improve ease of translating template title tags This patch uses the cities administration page as a proof-of-concept for using the [% t() %] construction to wrap translatable string in template <title> tags. This should result in a significant improvement in translatability. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po you should no longer see a reference to cities.tt line 6, "#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6" - In fr-FR-messages.po you should see several strings which have been pulled individually from the <title> tag: - cities.tt:9, msgid "Modify city" - cities.tt:11, msgid "New city" - cities.tt:15, msgid "Confirm deletion of city" - cities.tt:19, msgid "Administration", msgid "Cities", msgid "Koha", and msgid "Administration" Translate the strings in fr-FR-messages.po and install the updated translation: perl misc/translator/translate install fr-FR Swith to the update language in the staff interface and confirm that the Cities page title is translated correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33551 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|I18N/L10N |Templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org