https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148655|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148656&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148656|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 149287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149287&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149287|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149317&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes.