[Bug 15290] New: SQL reports encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Bug ID: 15290 Summary: SQL reports encoding problem Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: vfernandes@keep.pt QA Contact: testopia@bugs.koha-community.org The problem appears when running a SQL report or exporting a SQL report. The column header are in incorrect encoding. Test plan: 1 - Add a new SQL report using the following SQL for example: SELECT borrowers.cardnumber 'Número cartão', CONCAT (borrowers.firstname, ' ' , borrowers.surname) Nome, categories.description Grupo, borrowers.branchcode Biblioteca,borrowers.dateenrolled 'Data de inscrição', borrowers.dateexpiry 'Data limite' FROM borrowers INNER JOIN categories ON borrowers.categorycode = categories.categorycode ORDER BY borrowers.cardnumber ASC 2 - Run the report 3 - The column headers are incorrect. 4 - Export the report to CSV. 5 - The column headers on the file are incorrect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master Assignee|gmcharlt@gmail.com |tomascohen@gmail.com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 45353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45353&action=edit Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #1)
- Export the report => SUCCESS: Encoding correct
It doesn't fix the exported files. Followup needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #2)
(In reply to Tomás Cohen Arazi from comment #1)
- Export the report => SUCCESS: Encoding correct
It doesn't fix the exported files. Followup needed.
Just fail in comma separated in tab separated and open document doesn't fail. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #4 from Vitor Fernandes <vfernandes@keep.pt> --- CSV fails. Tab separated text fails. Open Document spreadsheet it's fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Vitor Fernandes from comment #4)
CSV fails. Tab separated text fails. Open Document spreadsheet it's fine.
I'm working on it, I found some issues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45384&action=edit Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45384|0 |1 is obsolete| | --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45385&action=edit Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45385|0 |1 is obsolete| | --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45456&action=edit Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45353|0 |1 is obsolete| | --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45457&action=edit Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45456|0 |1 is obsolete| | Attachment #45457|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45501&action=edit Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45502&action=edit Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Linked to bug 11944. Must be backported to 3.22.x and 3.20.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Patches pushed to master! Thanks Hector and Tomas! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #15 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org