[Bug 11038] New: Custom CSS for Staff Login like OPAC/StaffIntranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Bug ID: 11038 Summary: Custom CSS for Staff Login like OPAC/StaffIntranet Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: ssammons@npelem.com QA Contact: testopia@bugs.koha-community.org Performing a simple color change to staff login screen, required file system access to create a new CSS file. As documented @ http://www.myacpl.org/koha/?p=612 , you must do that OR use the javascript hack. I am suggesting there be a simple way to add custom CSS without the need for file system access. You can use a text box with OPACUserCSS, can a that just be duplicated? As stated in bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7424 a custom store for custom-css is great, perhaps we could look at having an "upload file" buttom, or a simple file editor like WordPress uses for its theme editor, so you have file write access without being in the file system for said custom-css files? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Architecture, internals, |Templates |and plumbing | Version|unspecified |master Assignee|gmcharlt@gmail.com |oleonard@myacpl.org Summary|Custom CSS for Staff Login |Enable use of |like OPAC/StaffIntranet |IntranetUserCSS and | |intranetcolorstylesheet on | |staff client login page Severity|enhancement |normal --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- The staff client login page does not load CSS stored in the IntranetUserCSS system preference. While it does load intranetcolorstylesheet, it loads the file before it loads login.css, so any styles you add specific to the login page will be overridden by login.css. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- *** Bug 14475 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45219&action=edit Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|ASSIGNED |Needs Signoff Assignee|oleonard@myacpl.org |bgkriegel@gmail.com Patch complexity|--- |Trivial patch --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Owen Leonard from comment #1)
The staff client login page does not load CSS stored in the IntranetUserCSS system preference.
Is this by design? This patch fixes this in a simple way Could this affect other pages? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45219|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45220&action=edit Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example #login h1 a { height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add #login h1 { background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. Re-upload to fix examples -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45220|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 45237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45237&action=edit Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example #login h1 a { height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add #login h1 { background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. Re-upload to fix examples Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45237|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45273&action=edit Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example #login h1 a { height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add #login h1 { background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. Re-upload to fix examples Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Thanks Bernardo! Note: I would have preferred to see a switch to using Koha.Preference, but this works well enough. At some point we will have to require the use of Koha.Preference and start a cleanup project for prefs passed via pl scripts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org