[Bug 11286] New: Bug 10602 prevents to create new subfields in authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Bug ID: 11286 Summary: Bug 10602 prevents to create new subfields in authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Default value for authorities, added by Bug 10602, was forgotten in insert query, preventing to add new subfields in authorities -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10602 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23077&action=edit Bug 11286: FIX Add a new subfield to an authority frameworks Bug 10602 introduces a bug when adding a new subfield to an authority framework. A new parameter is added in a sql query but the placeholder is missing. Test plan: - edit an authority framework - add a new subfield - save - boom! DBD::mysql::st execute failed: called with 16 bind variables when 15 are needed at /home/home/src/admin/auth_subfields_structure.pl line 454. - apply the patch and try again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23077|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 23121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23121&action=edit [SIGNED-OFF] Bug 11286: FIX Add a new subfield to an authority frameworks Bug 10602 introduces a bug when adding a new subfield to an authority framework. A new parameter is added in a sql query but the placeholder is missing. Test plan: - edit an authority framework - add a new subfield - save - boom! DBD::mysql::st execute failed: called with 16 bind variables when 15 are needed at /home/home/src/admin/auth_subfields_structure.pl line 454. - apply the patch and try again Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors Tested trying to add subfield to 100, 2 for example. Without patch silently fails (but error is logged) With patch subfield creation or elimination is fine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23121|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23123&action=edit [PASSED QA] Bug 11286: FIX Add a new subfield to an authority frameworks Bug 10602 introduces a bug when adding a new subfield to an authority framework. A new parameter is added in a sql query but the placeholder is missing. Test plan: - edit an authority framework - add a new subfield - save - boom! DBD::mysql::st execute failed: called with 16 bind variables when 15 are needed at /home/home/src/admin/auth_subfields_structure.pl line 454. - apply the patch and try again Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors Tested trying to add subfield to 100, 2 for example. Without patch silently fails (but error is logged) With patch subfield creation or elimination is fine Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> One line fix for a bad bug. Confirmed the bug on master and the fix. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |10602 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org