[Bug 17578] New: Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Bug ID: 17578 Summary: Replace GetMemberDetails with GetMember Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org In order to unify the different subroutine of C4::Members and move them to Koha::Patrons, one of the steps is to remove GetMemberDetails. Here we will replace all occurrences of GetMemberDetails with GetMember. Additional informations will be retrieved when needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Depends on| |17579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 [Bug 17579] Add the Koha::Patron->is_expired method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57299&action=edit Bug 17578: GetMemberDetails - Add Koha::Patron::Category->effective_BlockExpiredPatronOpacActions This patch simply adds a new method to retrieve the correct value of BlockExpiredPatronOpacActions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57300&action=edit Bug 17578: GetMemberDetails - Remove BlockExpiredPatronOpacActions The correct way to get the value of BlockExpiredPatronOpacActions from a patron object is to get the patron category then call the effective_BlockExpiredPatronOpacActions: $patron->category->effective_BlockExpiredPatronOpacActions So this patch applies this change and remove this value from the GetMemberDetails subroutine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57301&action=edit Bug 17578: GetMemberDetails - Remove authflags - 2 This script is not used from the Koha codebase and does not seem very useful. We could rewrite it if needed later (ie. if someone complains I will rewrite it). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57302&action=edit Bug 17578: GetMemberDetails - Remove authflags - 1 GetMemberDetails create a authflags key, but this key is only used from 2 different places. One is a very simple script, which does not seem very usefull C4/SIP/interactive_members_dump.pl. I propose to simply remove it. The other one is the member-flags.pl script. What is done in this one is a bit weird since we a doing twice the same query (it was not highlighted before this patch). We will need to fix that later. At the moment the goal it to remove the GetMemberDetails subroutine without introducing any regressions (and so without adding big changes) Test plan: Select/unselect permissions for a patron, save and edit again. The behavior of the permission checkboxes should be ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57303&action=edit Bug 17578: GetMemberDetails - Remove amountoutstanding The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed. Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57304&action=edit Bug 17578: GetMemberDetails - Remove flags Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it. Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57305&action=edit Bug 17578: GetMemberDetails - Remove is_expired The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead. Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57306&action=edit Bug 17578: GetMemberDetails - Remove reservefee Same as other patches, reservefee is only used in opac-reserve.pl Test plan; Set reserve fee for a patron category Place a hold at the OPAC with one of these patrons. You must get a message about the reserve fee. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57307&action=edit Bug 17578: GetMemberDetails - Remove enrolmentperiod This value is not used anywhere Test plan: git grep enrolmentperiod| grep -v installer| grep -v translator|vim - should show you that I am right -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57308&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- When I go to circulation -> checking out, or to permission settings of patron I get: Can't use string ("19") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Members.pm line 194 19 is borrowernumber of my patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57304|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57322&action=edit Bug 17578: GetMemberDetails - Remove flags Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it. Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57305|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57323&action=edit Bug 17578: GetMemberDetails - Remove is_expired The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead. Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57306|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57324&action=edit Bug 17578: GetMemberDetails - Remove reservefee Same as other patches, reservefee is only used in opac-reserve.pl Test plan; Set reserve fee for a patron category Place a hold at the OPAC with one of these patrons. You must get a message about the reserve fee. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57307|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57325&action=edit Bug 17578: GetMemberDetails - Remove enrolmentperiod This value is not used anywhere Test plan: git grep enrolmentperiod| grep -v installer| grep -v translator|vim - should show you that I am right -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57308|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57326&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Continue testing: On the patron permission setting page I always see the same set of permisions... but when I tried to set some permissions, it is saved to the database Also there are these error messages in intranet-error.log, I'm not sure if it is related: moremember.pl: Problem = a value of activeBorrowerRelationship has been passed to param without key at /home/vagrant/kohaclone/C4/Templates.pm line 137., referer: http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=19 moremember.pl: Problem = a value of relatives_borrowernumbers has been passed to param without key at /home/vagrant/kohaclone/C4/Templates.pm line 137., referer: http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=19 When trying to place a hold in OPAC I got: The method category is not covered by tests! So I assume this bug should depend on bug 17555. Right? I think there will be conflict in t/db_dependent/Koha/Patrons.t (at least). Could you rebase on 17555 please? (If I am right, of course ;) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED Depends on| |17555 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Josef, yes you are right about the dependency. But I am stuck at the moment, I do not manage to maintain a dependency tree without conflicts. I am marking this one as blocker, hoping other will be pushed soon. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17555 [Bug 17555] Add Koha::Patron->category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- OK, thank you. I'll try to get back when dependecies will be pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17522 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522 [Bug 17522] opac-user.pl gives error of OpacRenewalAllowed is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57299|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #1)
Created attachment 57299 [details] [review] Bug 17578: GetMemberDetails - Add Koha::Patron::Category->effective_BlockExpiredPatronOpacActions
This patch simply adds a new method to retrieve the correct value of BlockExpiredPatronOpacActions.
This patch has been moved to its own bug, see bug 17604. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17522 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522 [Bug 17522] opac-user.pl gives error of OpacRenewalAllowed is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Dependecies were pushed, could you please look at other issues from comment 17? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57300|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57793&action=edit Bug 17578: GetMemberDetails - Remove BlockExpiredPatronOpacActions The correct way to get the value of BlockExpiredPatronOpacActions from a patron object is to get the patron category then call the effective_BlockExpiredPatronOpacActions: $patron->category->effective_BlockExpiredPatronOpacActions So this patch applies this change and remove this value from the GetMemberDetails subroutine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57302|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57794&action=edit Bug 17578: GetMemberDetails - Remove authflags - 1 GetMemberDetails create a authflags key, but this key is only used from 2 different places. One is a very simple script, which does not seem very usefull C4/SIP/interactive_members_dump.pl. I propose to simply remove it. The other one is the member-flags.pl script. What is done in this one is a bit weird since we a doing twice the same query (it was not highlighted before this patch). We will need to fix that later. At the moment the goal it to remove the GetMemberDetails subroutine without introducing any regressions (and so without adding big changes) Test plan: Select/unselect permissions for a patron, save and edit again. The behavior of the permission checkboxes should be ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57301|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57795&action=edit Bug 17578: GetMemberDetails - Remove authflags - 2 This script is not used from the Koha codebase and does not seem very useful. We could rewrite it if needed later (ie. if someone complains I will rewrite it). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57303|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57796&action=edit Bug 17578: GetMemberDetails - Remove amountoutstanding The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed. Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57322|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57797&action=edit Bug 17578: GetMemberDetails - Remove flags Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it. Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57323|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57798&action=edit Bug 17578: GetMemberDetails - Remove is_expired The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead. Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57324|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57799&action=edit Bug 17578: GetMemberDetails - Remove reservefee Same as other patches, reservefee is only used in opac-reserve.pl Test plan; Set reserve fee for a patron category Place a hold at the OPAC with one of these patrons. You must get a message about the reserve fee. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57325|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57800&action=edit Bug 17578: GetMemberDetails - Remove enrolmentperiod This value is not used anywhere Test plan: git grep enrolmentperiod| grep -v installer| grep -v translator|vim - should show you that I am right -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57326|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57801&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #25)
Created attachment 57796 [details] [review] Bug 17578: GetMemberDetails - Remove amountoutstanding
The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed.
Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message
Does not work for me, sorry... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #26)
Created attachment 57797 [details] [review] Bug 17578: GetMemberDetails - Remove flags
Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it.
Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else.
in members/members-flags.pl, line 96: if ( $bor->{flags} && $bor->{flags} & 2**$bit ) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #27)
Created attachment 57798 [details] [review] Bug 17578: GetMemberDetails - Remove is_expired
The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead.
Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts
Does not work for me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- The other patches does work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57808&action=edit But 17578: (followup) amountoutstanding -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #31)
(In reply to Jonathan Druart from comment #25)
Created attachment 57796 [details] [review] [review] Bug 17578: GetMemberDetails - Remove amountoutstanding
The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed.
Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message
Does not work for me, sorry...
Good catch, fixed. It worked in some situations (lot of account lines). (In reply to Josef Moravec from comment #32)
(In reply to Jonathan Druart from comment #26)
Created attachment 57797 [details] [review] [review] Bug 17578: GetMemberDetails - Remove flags
Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it.
Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else.
in members/members-flags.pl, line 96:
if ( $bor->{flags} && $bor->{flags} & 2**$bit ) {
Yes actually this one is ok because we need the borrowers.flags value from the DB and not the "flags" set by C4::Members::patronflags. (In reply to Josef Moravec from comment #33)
(In reply to Jonathan Druart from comment #27)
Created attachment 57798 [details] [review] [review] Bug 17578: GetMemberDetails - Remove is_expired
The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead.
Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts
Does not work for me
Could you please detail, it looks ok here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> ---
(In reply to Jonathan Druart from comment #27)
Created attachment 57798 [details] [review] [review] [review] Bug 17578: GetMemberDetails - Remove is_expired
The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead.
Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts
Does not work for me
Could you please detail, it looks ok here.
Sorry, my mistake, it works ok. Continue testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #38 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57817&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove BlockExpiredPatronOpacActions The correct way to get the value of BlockExpiredPatronOpacActions from a patron object is to get the patron category then call the effective_BlockExpiredPatronOpacActions: $patron->category->effective_BlockExpiredPatronOpacActions So this patch applies this change and remove this value from the GetMemberDetails subroutine. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #39 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57818&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove authflags - 1 GetMemberDetails create a authflags key, but this key is only used from 2 different places. One is a very simple script, which does not seem very usefull C4/SIP/interactive_members_dump.pl. I propose to simply remove it. The other one is the member-flags.pl script. What is done in this one is a bit weird since we a doing twice the same query (it was not highlighted before this patch). We will need to fix that later. At the moment the goal it to remove the GetMemberDetails subroutine without introducing any regressions (and so without adding big changes) Test plan: Select/unselect permissions for a patron, save and edit again. The behavior of the permission checkboxes should be ok Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #40 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57819&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove authflags - 2 This script is not used from the Koha codebase and does not seem very useful. We could rewrite it if needed later (ie. if someone complains I will rewrite it). Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57820&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove amountoutstanding The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed. Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57821&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove flags Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it. Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57822&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove is_expired The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead. Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57823&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove reservefee Same as other patches, reservefee is only used in opac-reserve.pl Test plan; Set reserve fee for a patron category Place a hold at the OPAC with one of these patrons. You must get a message about the reserve fee. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57824&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove enrolmentperiod This value is not used anywhere Test plan: git grep enrolmentperiod| grep -v installer| grep -v translator|vim - should show you that I am right Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #46 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57825&action=edit [SIGNED-OFF] Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57793|0 |1 is obsolete| | Attachment #57794|0 |1 is obsolete| | Attachment #57795|0 |1 is obsolete| | Attachment #57796|0 |1 is obsolete| | Attachment #57797|0 |1 is obsolete| | Attachment #57798|0 |1 is obsolete| | Attachment #57799|0 |1 is obsolete| | Attachment #57800|0 |1 is obsolete| | Attachment #57801|0 |1 is obsolete| | Attachment #57808|0 |1 is obsolete| | --- Comment #47 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57826&action=edit [SIGNED-OFF] But 17578: (followup) amountoutstanding Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Bug 17578 depends on bug 17555, which changed state. Bug 17555 Summary: Add Koha::Patron->category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17555 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- t/db_dependent/Members.t ............................... 1/79 # Failed test 'TrackLastPatronActivity - 3 patrons must be deleted' # at t/db_dependent/Members.t line 355. # got: '2' # expected: '3' # Looks like you planned 79 tests but ran 77. # Looks like you failed 1 test of 77 run. t/db_dependent/Members.t ............................... Dubious, test returned 1 (wstat 256, 0x100) Failed 3/79 subtests Test Summary Report ------------------- t/db_dependent/Members.t (Wstat: 256 Tests: 77 Failed: 1) Failed test: 64 Non-zero exit status: 1 Parse errors: Bad plan. You planned 79 tests but ran 77. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #48)
t/db_dependent/Members.t ............................... 1/79 # Failed test 'TrackLastPatronActivity - 3 patrons must be deleted'
Not related, see bug 17713 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- fatal: sha1 information is lacking or useless (circ/circulation.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17578: GetMemberDetails - Remove GetMemberDetails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57825|0 |1 is obsolete| | Attachment #57826|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57972&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57973&action=edit But 17578: (followup) amountoutstanding Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57817|0 |1 is obsolete| | --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57974&action=edit Bug 17578: GetMemberDetails - Remove BlockExpiredPatronOpacActions The correct way to get the value of BlockExpiredPatronOpacActions from a patron object is to get the patron category then call the effective_BlockExpiredPatronOpacActions: $patron->category->effective_BlockExpiredPatronOpacActions So this patch applies this change and remove this value from the GetMemberDetails subroutine. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57818|0 |1 is obsolete| | --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57975&action=edit Bug 17578: GetMemberDetails - Remove authflags - 1 GetMemberDetails create a authflags key, but this key is only used from 2 different places. One is a very simple script, which does not seem very usefull C4/SIP/interactive_members_dump.pl. I propose to simply remove it. The other one is the member-flags.pl script. What is done in this one is a bit weird since we a doing twice the same query (it was not highlighted before this patch). We will need to fix that later. At the moment the goal it to remove the GetMemberDetails subroutine without introducing any regressions (and so without adding big changes) Test plan: Select/unselect permissions for a patron, save and edit again. The behavior of the permission checkboxes should be ok Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57819|0 |1 is obsolete| | --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57976&action=edit Bug 17578: GetMemberDetails - Remove authflags - 2 This script is not used from the Koha codebase and does not seem very useful. We could rewrite it if needed later (ie. if someone complains I will rewrite it). Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57820|0 |1 is obsolete| | --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57977&action=edit Bug 17578: GetMemberDetails - Remove amountoutstanding The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed. Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57821|0 |1 is obsolete| | --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57978&action=edit Bug 17578: GetMemberDetails - Remove flags Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it. Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57822|0 |1 is obsolete| | --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57979&action=edit Bug 17578: GetMemberDetails - Remove is_expired The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead. Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57823|0 |1 is obsolete| | --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57980&action=edit Bug 17578: GetMemberDetails - Remove reservefee Same as other patches, reservefee is only used in opac-reserve.pl Test plan; Set reserve fee for a patron category Place a hold at the OPAC with one of these patrons. You must get a message about the reserve fee. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57972|0 |1 is obsolete| | --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57981&action=edit Bug 17578: GetMemberDetails - Remove enrolmentperiod This value is not used anywhere Test plan: git grep enrolmentperiod| grep -v installer| grep -v translator|vim - should show you that I am right Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #61 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57982&action=edit Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57973|0 |1 is obsolete| | --- Comment #62 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57983&action=edit But 17578: (followup) amountoutstanding Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57984&action=edit QA Follow - Adjust number of tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058 [Bug 7058] GetMemberDetails must die! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal@gmail.com --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 7058 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 [Bug 18504] Amount owed on fines tab should be formatted as price if <10 or credit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18504 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 [Bug 18504] Amount owed on fines tab should be formatted as price if <10 or credit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21832 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org