https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #31)
(In reply to Jonathan Druart from comment #25)
Created attachment 57796 [details] [review] [review] Bug 17578: GetMemberDetails - Remove amountoutstanding
The amountoutstanding value set by GetMemberDetails was only used in a few places. In that case it makes sense to only retrieve it when needed.
Test plan: 1/ Add fines to a patron, on the OPAC patron info page, you should see a "Fines" tab 2/ Add credit to a patron, you should see the credit displayed 3/ Set the pref maxoutstanding to 3 4/ Add a fine of 4 to a patron 5/ Try to place an hold for this patron => You should get a "too much oweing" message
Does not work for me, sorry...
Good catch, fixed. It worked in some situations (lot of account lines). (In reply to Josef Moravec from comment #32)
(In reply to Jonathan Druart from comment #26)
Created attachment 57797 [details] [review] [review] Bug 17578: GetMemberDetails - Remove flags
Same as authflags, a flags key is set containing all the patron flags. It is only used in a few places and it's better to call C4::Members::patronflags when we need it.
Test plan: Look at the diff and confirm that the change make sense Use git grep to confirm we do not use the flags somewhere else.
in members/members-flags.pl, line 96:
if ( $bor->{flags} && $bor->{flags} & 2**$bit ) {
Yes actually this one is ok because we need the borrowers.flags value from the DB and not the "flags" set by C4::Members::patronflags. (In reply to Josef Moravec from comment #33)
(In reply to Jonathan Druart from comment #27)
Created attachment 57798 [details] [review] [review] Bug 17578: GetMemberDetails - Remove is_expired
The is_expired value is used in 2 places, let's use Koha::Patron->is_expired instead.
Test plan: Depending on the different value of BlockExpiredPatronOpacActions for the patron category, a patron must be blocked if he has expired. Confirm that behavior from opac-renew and opac-reserve scripts
Does not work for me
Could you please detail, it looks ok here. -- You are receiving this mail because: You are watching all bug changes.