[Bug 3536] New: Checked In item requiring transfer does not consistently trigger transfer prompt
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 Summary: Checked In item requiring transfer does not consistently trigger transfer prompt Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Circulation AssignedTo: gmcharlt@gmail.com ReportedBy: mcoalwell@nekls.org CC: smoreland@nekls.org Estimated Hours: 0.0 Change sponsored?: --- Regardless of how many times an item is Checked In, if the Check In occurs at a library other than the target library, then a transfer prompt should appear, every time, to instruct the staff person to transfer the item to the target library. It doesn't make any sense for the prompt to appear once, and only once. Koha needs to show a message when: currentlocation != homebranch and status = available. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 --- Comment #1 from Sharon Moreland <smoreland@nekls.org> 2009-08-17 16:21:39 --- This bug goes with 3298, an enhancement request for a "check item status" function that is more benign than the Check In function. A Scenario: An item belonging to Library A is returned to Library B after being checked out to a patron from Library B and the staff at Library B fail to see the transit prompt and accidentally reshelve the item. The item is later found. A staff member from Library B scans the barcode using the Check In function. Koha 'clears' the transit and changes the current location from Library A to Library B, rather than displaying the transit prompt again. With Koha is it works now, the staff member should have searched for the item via a catalog search, then referred to the holdings table to see the status of the item. In our consortium, the current location and homebranch should only mis-match if an item is: in transit to a location to fill a hold, on the holds shelf for a patron, or checked out. I would argue that an item in transit to a location to fill a hold should NOT have a status of 'available', but that's a different enhancement request, I suppose. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 Cookie Wolfrom <cookie.wolfrom@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cookie.wolfrom@liblime.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 --- Comment #2 from Mickey Coalwell <mcoalwell@nekls.org> 2009-08-17 16:34:18 --- Created an attachment (id=1051) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1051) Showing On Hold Items on Search Results -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 --- Comment #3 from Mickey Coalwell <mcoalwell@nekls.org> 2009-08-17 16:35:06 --- There is a crucial piece to addressing this scenario that Dan Sweeney spec'd for us before he left, and it concerns the creation of a new “On Hold” group that will indicate what items are on hold. These items will not be counted as “Available.” Additionally, for items in transit, a new “In transit” display status has been added recently. This shows on both the search results screen and the record details screen. Items that are in transit do not count as available. This change has not been delivered to customers yet. [as of 8/13/09]. I'm attaching the entire spec for anyone interested. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 David Schuster <dschust1@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dschust1@gmail.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Severity|enhancement |blocker --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2009-12-22 17:48:50 --- This is not an enhancement, this is a requirement! If I have an item from Library A and I check it in at Library B, I should be prompted to return it to Library A whether or not the item was checked out. This is broken--I get no prompt. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2009-12-22 19:31:07 --- Some notes for chris: http://paste.workbuffer.org/98 ----------------------------- 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1460) $doreturn = 0; 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1461) # bailing out here - in this case, current desired 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1462) # is to act as if no return ever happened at all. 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1463) # FIXME - even in an indy branches situation, there 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1464) # still be an option for the library to accept the 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1465) # and transfer it to its owning library. 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1466) return ( $doreturn, $messages, $issue, $borrower ); http://paste.workbuffer.org/99 ----------------------------- if ($doreturn and ($branch ne $hbr) and not $messages->{'WrongTransfer'} and ($validTransfert ne 1) ){ if ( C4::Context->preference("AutomaticItemReturn" ) or (C4::Context->preference("UseBranchTransferLimits") and ! IsBranchTransferAllowed($branch, $hbr, $item->{C4::Context->preference("BranchTransferLimitsType")} ) )) { $debug and warn sprintf "about to call ModItemTransfer(%s, %s, %s)", $item->{'itemnumber'},$branch, $hbr; $debug and warn "item: " . Dumper($item); ModItemTransfer($item->{'itemnumber'}, $branch, $hbr); $messages->{'WasTransfered'} = 1; } else { $messages->{'NeedsTransfer'} = 1; # TODO: instead of 1, specify branchcode that the transfer SHOULD go to, $i$ } } http://paste.workbuffer.org/100 ----------------------------- if ($issue and $issue->{borrowernumber}) { $borrower = C4::Members::GetMemberDetails($issue->{borrowernumber}) or die "Data inconsistency: barcode $barcode (itemnumber:$itemnumber) claims to be issued to non-existant borro$ . Dumper($issue) . "\n"; } else { $messages->{'NotIssued'} = $barcode; # even though item is not on loan, it may still be transferred; therefore, get current branch info $doreturn = 0; # No issue, no borrowernumber. ONLY if $doreturn, *might* you have a $borrower later. } -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz AssignedTo|gmcharlt@gmail.com |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2009-12-23 01:11:49 --- Further investigation We have discovered the culprit. my $hbr = $item->{C4::Context->preference("HomeOrHoldingBranch")} || ''; So if you have HoldingBranch set .. then it won't attempt a transfer back to the items homebranch, but to its holdingbranch instead. Which I don't think is the intended behaviour. This overrides the syspref to do automatic transfer to homebranch. I think $hbr should always get the value of the items homebranch. This plus the other error (the fact a transfer is only done if an item is returned) cause the behaviour. I can send a patch to fix, but I'd like some agreement that checking the items homebranch is the right thing to do when working out if a transfer is needed. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 Nahuel Angelinetti <nahuel.angelinetti@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nahuel.angelinetti@biblibre. | |com AssignedTo|chris@bigballofwax.co.nz |nahuel.angelinetti@biblibre. | |com --- Comment #7 from Nahuel Angelinetti <nahuel.angelinetti@biblibre.com> 2009-12-23 08:55:50 --- I'll do a patch for this, a new syspref will be available for returns: HomeOrholdingbranchReturn The updatedatabase will copy the HomeOrholdingbranch in the new one. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 --- Comment #8 from Nahuel Angelinetti <nahuel.angelinetti@biblibre.com> 2009-12-23 14:53:19 --- Created an attachment (id=1414) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1414) bugfix -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 Nahuel Angelinetti <nahuel.angelinetti@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2009-12-26 08:44:42 --- Patch reformatted and sent for master also -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nahuel.angelinetti@biblibre.|chris@bigballofwax.co.nz |com | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2009-12-26 08:45:38 --- Created an attachment (id=1421) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1421) Patch for bugfix on master branch -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1421 is|0 |1 obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2009-12-26 08:51:55 --- Created an attachment (id=1422) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1422) Patch for master -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (2)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com -
bugzilla-daemon＠liblime.com