http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2009-12-22 19:31:07 --- Some notes for chris: http://paste.workbuffer.org/98 ----------------------------- 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1460) $doreturn = 0; 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1461) # bailing out here - in this case, current desired 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1462) # is to act as if no return ever happened at all. 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1463) # FIXME - even in an indy branches situation, there 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1464) # still be an option for the library to accept the 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1465) # and transfer it to its owning library. 5593a281 (Galen Charlton 2009-08-23 10:01:19 -0400 1466) return ( $doreturn, $messages, $issue, $borrower ); http://paste.workbuffer.org/99 ----------------------------- if ($doreturn and ($branch ne $hbr) and not $messages->{'WrongTransfer'} and ($validTransfert ne 1) ){ if ( C4::Context->preference("AutomaticItemReturn" ) or (C4::Context->preference("UseBranchTransferLimits") and ! IsBranchTransferAllowed($branch, $hbr, $item->{C4::Context->preference("BranchTransferLimitsType")} ) )) { $debug and warn sprintf "about to call ModItemTransfer(%s, %s, %s)", $item->{'itemnumber'},$branch, $hbr; $debug and warn "item: " . Dumper($item); ModItemTransfer($item->{'itemnumber'}, $branch, $hbr); $messages->{'WasTransfered'} = 1; } else { $messages->{'NeedsTransfer'} = 1; # TODO: instead of 1, specify branchcode that the transfer SHOULD go to, $i$ } } http://paste.workbuffer.org/100 ----------------------------- if ($issue and $issue->{borrowernumber}) { $borrower = C4::Members::GetMemberDetails($issue->{borrowernumber}) or die "Data inconsistency: barcode $barcode (itemnumber:$itemnumber) claims to be issued to non-existant borro$ . Dumper($issue) . "\n"; } else { $messages->{'NotIssued'} = $barcode; # even though item is not on loan, it may still be transferred; therefore, get current branch info $doreturn = 0; # No issue, no borrowernumber. ONLY if $doreturn, *might* you have a $borrower later. } -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.