[Bug 16136] New: Koha::Patron contains 'return undef' and fails critic tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 Bug ID: 16136 Summary: Koha::Patron contains 'return undef' and fails critic tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: - Run $ TEST_QA=1 prove t/00-testcritic.t => FAIL: Koha::Patron makes the tests fail. While a minor issue, this is really important because the packages build procedure runs the db-independent tests and they need to pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15656 Assignee|gmcharlt@gmail.com |tomascohen@gmail.com Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 [Bug 15656] Move the guarantor/guarantees code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49456&action=edit Bug 16136: Koha::Patron contains 'return undef' and fails critic tests This patch fixes this issue. To test: - Run $ TEST_QA=1 prove t/00-testcritic.t => FAIL: Koha::Patron makes the tests fail. - Apply the patch - Run $ TEST_QA=1 prove t/00-testcritic.t => SUCCESS: tests PASS - Sign off Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49456|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49458&action=edit Bug 16136: Koha::Patron contains 'return undef' and fails critic tests This patch fixes this issue. To test: - Run $ TEST_QA=1 prove t/00-testcritic.t => FAIL: Koha::Patron makes the tests fail. - Apply the patch - Run $ TEST_QA=1 prove t/00-testcritic.t => SUCCESS: tests PASS - Sign off Regards Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16136 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org