[Bug 16143] New: Wrong icon PATH on virtualshelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 Bug ID: 16143 Summary: Wrong icon PATH on virtualshelves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: - On current master/3.22.x - Have some itemtypes with icons set - Have some biblios matching the itemtypes - Add them to a public list - Do a search in the OPAC for any of those biblios => SUCCESS: icons show correctly - Choose the list => FAIL: icons fail to show, URL points to /intranet-tmpl/.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49501&action=edit Bug 16143: Make opac-shelves.pl generate OPAC itype images path This patch makes icons point to the OPAC path instead of intranet's. To test: - On current master/3.22.x - Have some itemtypes with icons set - Have some biblios matching the itemtypes - Add them to a public list - Do a search in the OPAC for any of those biblios => SUCCESS: icons show correctly - Choose the list => FAIL: icons fail to show, URL points to /intranet-tmpl/.... - Apply the patch, reload => SUCCESS: icons show correctly - Sign off :-D Sponsored-by: American Numismatic Society -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 49501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49501 Bug 16143: Make opac-shelves.pl generate OPAC itype images path Review of attachment 49501: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16143&attachment=49501) ----------------------------------------------------------------- ::: opac/opac-shelves.pl @@ +259,4 @@
}
my $marcflavour = C4::Context->preference("marcflavour"); + my $itemtypeinfo = getitemtypeinfo( $content->biblionumber->biblioitems->first->itemtype, 'opac' );
Oooo... good catch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49501|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49509&action=edit Bug 16143: Make opac-shelves.pl generate OPAC itype images path This patch makes icons point to the OPAC path instead of intranet's. To test: - On current master/3.22.x - Have some itemtypes with icons set - Have some biblios matching the itemtypes - Add them to a public list - Do a search in the OPAC for any of those biblios => SUCCESS: icons show correctly - Choose the list => FAIL: icons fail to show, URL points to /intranet-tmpl/.... - Apply the patch, reload => SUCCESS: icons show correctly - Sign off :-D Sponsored-by: American Numismatic Society NOTE: I had to set item-level_itypes to 'biblio record' in order to trigger this. My icon's showed, but the path was wrong. This patch corrects it. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch is obviously right and display of the icon is ok. Testing without the patch I noticed that the icon was displaying for me as well (git installation, using a bridge icon). I think the display for item types without icons needs to be corrected (separately). It shows the description twice in these cases and should probably show nothing or the description only once. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49509|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49510&action=edit [PASSED QA] Bug 16143: Make opac-shelves.pl generate OPAC itype images path This patch makes icons point to the OPAC path instead of intranet's. To test: - On current master/3.22.x - Have some itemtypes with icons set - Have some biblios matching the itemtypes - Add them to a public list - Do a search in the OPAC for any of those biblios => SUCCESS: icons show correctly - Choose the list => FAIL: icons fail to show, URL points to /intranet-tmpl/.... - Apply the patch, reload => SUCCESS: icons show correctly - Sign off :-D Sponsored-by: American Numismatic Society NOTE: I had to set item-level_itypes to 'biblio record' in order to trigger this. My icon's showed, but the path was wrong. This patch corrects it. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16143 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org