https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard@gmail.com | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65317|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 65319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65319&action=edit Bug 16117 - Feature request: Log borrower cardnumbers and item barcodes which are not valid We should be able to log invalid patrons and items for trouble-shooting purposes. It is especially helpful when determining if there are issues with barcode scanners. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Attempt to check out to an invalid patron cardnumber 4) Attempt to checkout a non-existent barcode 5) Attempt to check in a non-existant barcode 6) Note nothing new is added to the statistics table 7) Enable the new system preferences LogInvalidItems and LogInvalidPatrons 8) Repeat steps 4-6 9) Note each action creates a new line in the statistics table Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Feature request: Log |Log borrower cardnumbers |borrower cardnumbers and |and item barcodes which are |item barcodes which are not |not valid |valid | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #4)

Just a thought: Koha::Statistics->invalid_item( { item => $barcode } ); sounds like it will return something, not it will actually write.

I would suggest to rename the method with something more meaningful. Waiting for another QA opinion.

I agree, something like "log_invalid_item" or similar would be better. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: Patch doesn't apply! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65319|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73177&action=edit Bug 16117: Log borrower cardnumbers and item barcodes which are not valid We should be able to log invalid patrons and items for trouble-shooting purposes. It is especially helpful when determining if there are issues with barcode scanners. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Attempt to check out to an invalid patron cardnumber 4) Attempt to checkout a non-existent barcode 5) Attempt to check in a non-existant barcode 6) Note nothing new is added to the statistics table 7) Enable the new system preferences LogInvalidItems and LogInvalidPatrons 8) Repeat steps 4-6 9) Note each action creates a new line in the statistics table Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply, please rebase! 73178 - Bug 16117: Give methods better names Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16117: Log borrower cardnumbers and item barcodes which are not valid Using index info to reconstruct a base tree... M C4/Circulation.pm M circ/circulation.pl M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M t/db_dependent/Stats.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Stats.t CONFLICT (content): Merge conflict in t/db_dependent/Stats.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging circ/circulation.pl Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm Failed to merge in the changes. Patch failed at 0001 Bug 16117: Log borrower cardnumbers and item barcodes which are not valid The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16117-Log-borrower-cardnumbers-and-item-barcod-t7ci5h.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73177|0 |1 is obsolete| | Attachment #73178|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81273&action=edit Bug 16117: Log borrower cardnumbers and item barcodes which are not valid We should be able to log invalid patrons and items for trouble-shooting purposes. It is especially helpful when determining if there are issues with barcode scanners. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Attempt to check out to an invalid patron cardnumber 4) Attempt to checkout a non-existent barcode 5) Attempt to check in a non-existant barcode 6) Note nothing new is added to the statistics table 7) Enable the new system preferences LogInvalidItems and LogInvalidPatrons 8) Repeat steps 4-6 9) Note each action creates a new line in the statistics table Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) QA script fails on POD: FAIL Koha/Statistics.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' 2) The prefs appear under "Circulation", I would have expected them under "Logs". Can you please move or explain? 3) This covers Checkout and Checkin, but what about scanned renewals? 4) remove "Feature request" from atomicupdate print :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81273|0 |1 is obsolete| | Attachment #81274|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153493&action=edit Bug 16117: Log borrower cardnumbers and item barcodes which are not valid We should be able to log invalid patrons and items for trouble-shooting purposes. It is especially helpful when determining if there are issues with barcode scanners. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Attempt to check out to an invalid patron cardnumber 4) Attempt to checkout a non-existent barcode 5) Attempt to check in a non-existant barcode 6) Note nothing new is added to the statistics table 7) Enable the new system preferences LogInvalidItems and LogInvalidPatrons 8) Repeat steps 4-6 9) Note each action creates a new line in the statistics table Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #15)

Having a quick look here, some small changes need to be made:

1) System preferences in the yaml file are using yes/no instead of 0/1.

Fixed!

2) Not all points from comment#13 have been replied to or resolved, especially 2 and 3.

Prefs moved, and scanned renewals will be captured as they will go though CanBookBeIssued -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I get invalid_item logged when try a check out and check in but for renewals I get nothing either from /cgi-bin/koha/circ/renew.pl or from the header_search bar switched to "renew". Did I miss something? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Log borrower cardnumbers |Log patron cardnumbers and |and item barcodes which are |item barcodes which are not |not valid |valid -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but this needs some work to apply again: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16117: Log borrower cardnumbers and item barcodes which are not valid Using index info to reconstruct a base tree... M C4/Circulation.pm M circ/circulation.pl M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M opac/sco/sco-main.pl A t/db_dependent/Stats.t Falling back to patching base and 3-way merge... CONFLICT (modify/delete): t/db_dependent/Stats.t deleted in HEAD and modified in Bug 16117: Log borrower cardnumbers and item barcodes which are not valid. Version Bug 16117: Log borrower cardnumbers and item barcodes which are not valid of t/db_dependent/Stats.t left in tree. Auto-merging opac/sco/sco-main.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging circ/circulation.pl Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 16117: Log borrower cardnumbers and item barcodes which are not valid hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16117-Log-borrower-cardnumbers-and-item-barcod-0_3t9irp.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158532&action=edit Bug 16117: (QA follow-up) Fix QA issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | Status|Signed Off |Failed QA --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Victor Grousset/tuxayo from comment #18)

I get invalid_item logged when try a check out and check in but for renewals I get nothing either from /cgi-bin/koha/circ/renew.pl or from the header_search bar switched to "renew".

Did I miss something?

This is still not working. ----

Log scanned invalid patron identifiers as statistics

The logging feature of Koha isn't referred as statistics. Is it called like that because these logs are not viewable in the log viewer? And only in the statistics table. Any opinions to confirm that this feature does not need the results viewable via the UI? I would have guessed yes but better get opinions from people knowing better the user needs for this. --- note: there is no way to differentiate an invalid cardnumber from just searching a patron by name in the checkout header_search bar. So enabling logging here will lead to all of those searches by name being logged as false positives. I guess that's just a tradeoff the feature inherent of having field combining name and cardnumber search. not much to do here. --- note: record details => holds => search patron: it's not logged but it looks ok to leave that for a follow up ticket if there is actual demand. (previous point will also apply here) --- note: self check-in and self check-out works 👍 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- I don't think this feature is worth pursuing any longer at this time. IIRC it was basically to show that a library's barcode scanning was occasionally misreading barcodes and not Koha failing to find the correct barcode. At this point we could implement something along these lines as a plugin if it were ever needed again. -- You are receiving this mail because: You are watching all bug changes.