https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190922&action=edit Bug 41530: Rename item_type => item_type_id in transfer_limits API spec Following the API consistency work in bug 41456, this patch renames the item_type field to item_type_id in the transfer_limits API endpoints and definitions. The field should only be named item_type when it contains an embedded object (type: object/null). When it contains a foreign key ID (type: string/null), it should be named item_type_id for consistency. Changes: - Updated api/v1/swagger/definitions/transfer_limit.yaml - Updated api/v1/swagger/paths/transfer_limits.yaml (including documentation) - Updated Koha::Item::Transfer::Limit->to_api_mapping - Updated Koha::REST::V1::TransferLimits error messages - Updated t/db_dependent/api/v1/transfer_limits.t - Updated koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt Test plan: 1. Run API tests: prove t/db_dependent/api/v1/transfer_limits.t 2. Visit /cgi-bin/koha/admin/transfer_limits.pl 3. Select an item type from the dropdown 4. Check/uncheck transfer limits - verify they work correctly 5. Confirm the API requests use item_type_id field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190924&action=edit Bug 41530: Rename item_type => item_type_id in clubs holds API spec Following the API consistency work in bug 41456, this patch renames the item_type field to item_type_id in the clubs holds API endpoint. The field should only be named item_type when it contains an embedded object (type: object/null). When it contains a foreign key ID (type: string/null), it should be named item_type_id for consistency. Changes: - Updated api/v1/swagger/paths/clubs.yaml - Updated Koha::REST::V1::Clubs::Holds to use item_type_id Test plan: 1. Run API tests: prove t/db_dependent/api/v1/clubs_holds.t 2. Verify club holds continue to work correctly 3. Check that item_type_id field is properly mapped in API requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I think this needs to be adjusted: suggestion/suggestion.tt 1366 if(row.item_type && row._strings.item_type.str) node += '; <span class="suggestion_itype"><em>%s</em></span>'.format(row._strings.item_type.str); maybe this one (to confirm): reserve/request.tt 1677 data.item_type = $('input[name="itemtype"]').val()||null; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190922|0 |1 is obsolete| | Attachment #190923|0 |1 is obsolete| | Attachment #190924|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 202027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202027&action=edit Bug 41530: Rename item_type => item_type_id in suggestions API spec Following the API consistency work in bug 41456, this patch renames the item_type field to item_type_id in the suggestions API definition. The field should only be named item_type when it contains an embedded object (type: object/null). When it contains a foreign key ID (type: string/null), it should be named item_type_id for consistency. Changes: - Updated api/v1/swagger/definitions/suggestion.yaml - Updated Koha::Suggestion->to_api_mapping Test plan: 1. Run API tests: prove t/db_dependent/api/v1/suggestions.t 2. Verify suggestions API continues to work correctly 3. Check that item_type_id field is properly mapped in API responses -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There was a small conflict in the unit test file I fixed and since they still pass, I assume it was correct. I am attaching the rebased patches. QA tests pass. Can you please take a look at Joubu's comment? (In reply to Jonathan Druart from comment #4)

I think this needs to be adjusted: suggestion/suggestion.tt 1366 if(row.item_type && row._strings.item_type.str) node += '; <span class="suggestion_itype"><em>%s</em></span>'.format(row._strings.item_type. str);

maybe this one (to confirm): reserve/request.tt 1677 data.item_type = $('input[name="itemtype"]').val()||null;

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks Katrin for the rebase and QA, and Joubu for the review. You were right, the two places you pointed at were still using the old names. I have added a follow-up patch (attachment below): * suggestion/suggestion.tt: the suggestions table read row.item_type and its string, so with the rename the format of a suggestion was no longer shown. It now uses row.item_type_id and _strings.item_type_id. I checked on a suggestion with a format and it is displayed again. * reserve/request.tt: the club hold form posted item_type, which the clubs holds endpoint no longer accepts. It now posts item_type_id. I searched the templates, JS, Vue components and Cypress specs for other users of the three renamed fields and found none (the other item_type occurrences are the item_type object embedded on items, which is a different thing). The follow-up also adds API tests: suggestions expose, filter on and accept item_type_id, and club holds use item_type_id (and no longer accept item_type), and fixes a missing POD that QA flagged in Koha/Item/Transfer/Limit.pm. I have not exercised the club hold form in the browser (the API test covers the endpoint). Setting back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.