[Bug 42357] New: Holds table is missing patron name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Bug ID: 42357 Summary: Holds table is missing patron name Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: bibliothek@th-wildau.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com The holds queue table is only showing the patrons card number. Before the overhaul on holds module the patron column looked like preferred_name|first_name and surname (cardnumber) To test: - f.e. /cgi-bin/koha/reserve/request.pl?biblionumber=262 - enter a patron name f.e. acev - take a look at the patron column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42343 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #1 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 197370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197370&action=edit Bug 42357: Show patron details on holds table This patch reintroduces patron details in 'Existing holds' table by using $patron_to_html. test plan: a) get a nice fresh ktd and navigate to /cgi-bin/koha/reserve/request.pl?biblionumber=262 b) place a hold for a patron f.e. 23529000035676 c) take a look at the Existing holds tables patron column which only shows the patrons card number. d) apply patch and run 'yarn js:build' e) refresh /cgi-bin/koha/reserve/request.pl?biblionumber=262 f) the patron column now should show patrons name g) set system preference HidePatronName to 'Don't show' h) go to /cgi-bin/koha/reserve/request.pl?biblionumber=262 f) the patron column now should only show patrons names. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bibliothek@th-wildau.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- The mix of pascal case and snake case in holds.js (hide_patron_name: HidePatronName) was intentional as HidePatronName was set in request.tt which is part of 'Tidy all script tags - reserve' 42288 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #3 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 197532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197532&action=edit Bug 42357: Show patron details on holds table This patch reintroduces patron details in 'Existing holds' table by using $patron_to_html. test plan: a) get a nice fresh ktd and navigate to /cgi-bin/koha/reserve/request.pl?biblionumber=262 b) place a hold for a patron f.e. 23529000035676 c) take a look at the Existing holds tables patron column which only shows the patrons card number. d) apply patch and run 'yarn js:build' e) refresh /cgi-bin/koha/reserve/request.pl?biblionumber=262 f) the patron column now should show patrons name g) set system preference HidePatronName to 'Don't show' h) go to /cgi-bin/koha/reserve/request.pl?biblionumber=262 f) the patron column now should only show patrons names. Signed-off-by: Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |loreganlloyd@clamsnet.org --- Comment #4 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Quick clarification-- I believe the final step of the test plan should read: f) the patron column now should only show patrons number Also, wanted to note that I did verify that prior to the holds overhaul (thinking that work was done in bug 23269? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269) the patron name did show in the patron column on the holds table on /cgi-bin/koha/reserve/request.pl?biblionumber=262. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Cindy Murdock Ames <cmurdock@ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock@ccfls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- '<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=' + row.patron.patron_id + '">' + - data + + $patron_to_html(row.patron, { + url: true, + display_cardnumber: true, + hide_patron_name: HidePatronName, + }) + "</a>" This does not seem correct, we have a link within a link. <a>$patron_to_html(row.patron, {url: true})</a> Either remove the a tag, or the url: true. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Hayley Cheng <hacheng@pymblelc.nsw.edu.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hacheng@pymblelc.nsw.edu.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #6 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200786&action=edit Bug 42357: Show patron details on holds table This patch reintroduces patron details in 'Existing holds' table by using $patron_to_html. test plan: a) get a nice fresh ktd and navigate to /cgi-bin/koha/reserve/request.pl?biblionumber=262 b) place a hold for a patron f.e. 23529000035676 c) take a look at the Existing holds tables patron column which only shows the patrons card number. d) apply patch and run 'yarn js:build' e) refresh /cgi-bin/koha/reserve/request.pl?biblionumber=262 f) the patron column now should show patrons name g) set system preference HidePatronName to 'Don't show' h) go to /cgi-bin/koha/reserve/request.pl?biblionumber=262 f) the patron column now should only show the patrons card number. Signed-off-by: Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> --- followed Jonathans remark #5 and removed the outer html tag, also changed the test plan according to Lawrence #4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200786|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200888&action=edit Bug 42357: Show patron details on holds table This patch reintroduces patron details in 'Existing holds' table by using $patron_to_html. test plan: a) get a nice fresh ktd and navigate to /cgi-bin/koha/reserve/request.pl?biblionumber=262 b) place a hold for a patron f.e. 23529000035676 c) take a look at the Existing holds tables patron column which only shows the patrons card number. d) apply patch and run 'yarn js:build' e) refresh /cgi-bin/koha/reserve/request.pl?biblionumber=262 f) the patron column now should show patrons name g) set system preference HidePatronName to 'Don't show' h) go to /cgi-bin/koha/reserve/request.pl?biblionumber=262 f) the patron column now should only show the patrons card number. Signed-off-by: Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- Please backport to 25.11 if possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 justin.swink@littleelm.gov <Justin.Swink@littleelm.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Justin.Swink@littleelm.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the holds table release notes| |for a bibliographic record | |n the staff interface. It | |now shows the patron's | |name, instead of the | |patron's card number. | | | |(Use existing system | |HidePatronName system | |preference to hide patron | |names, for example for | |privacy reasons at | |circulation desks.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Text to go in the|This fixes the holds table |This fixes the holds table release notes|for a bibliographic record |for a bibliographic record |n the staff interface. It |n the staff interface. It |now shows the patron's |now shows the patron's name |name, instead of the |in addition to the patron's |patron's card number. |card number. | | |(Use existing system |(Use existing system |HidePatronName system |HidePatronName system |preference to hide patron |preference to hide patron |names, for example for |names, for example for |privacy reasons at |privacy reasons at |circulation desks.) |circulation desks.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the holds table |This fixes the holds table release notes|for a bibliographic record |for a bibliographic record |n the staff interface. It |in the staff interface. It |now shows the patron's name |now shows the patron's name |in addition to the patron's |in addition to the patron's |card number. |card number. | | |(Use existing system |(Use existing system |HidePatronName system |HidePatronName system |preference to hide patron |preference to hide patron |names, for example for |names, for example for |privacy reasons at |privacy reasons at |circulation desks.) |circulation desks.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Peter Washkevich <pwashkevich@sjcfl.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pwashkevich@sjcfl.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 [Bug 42915] Filtering Holds table by patron name or pickup library is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #11 from carthur@slolibrary.org <carthur@slolibrary.org> --- I would like to second Chris' comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #12 from Brendan Lawlor <blawlor@clamsnet.org> --- +1 for backport to 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- We are getting more and more complaints from libraries since 25.11.05 was released about this problem. It is disrupting workflows. We REALLY need this backported ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Rhonda Kuiper <rkuiper@roundrocktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov --- Comment #14 from Rhonda Kuiper <rkuiper@roundrocktexas.gov> --- +1 to Christopher's comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Christopher Davis <tubaclarinet@protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tubaclarinet@protonmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 --- Comment #15 from Christopher Davis <tubaclarinet@protonmail.com> --- Thank you to all who've worked on this. Our consortium would also like this patch backported to both V. 25.11 and V. 26.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Daren Kelly <global_gooner@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |global_gooner@yahoo.com --- Comment #16 from Daren Kelly <global_gooner@yahoo.com> --- This REALLY needs to be backported to 25.11 as originally planned. As Christopher Brannon said earlier, it is disrupting workflows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Adding my +1 for backporting :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42357 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com --- Comment #19 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Caroline Cyr La Rose from comment #17)
Adding my +1 for backporting :)
Yes, please, lets have a backport for 25.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org