https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42231 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Renew checkbox on |Fix accessibility issues in |opac-user.tt is missing a |OPAC summary table |form label | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42231 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 196684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196684&action=edit Bug 42231: Fix accessibility issues in OPAC summary table The OPAC summary page contains several accessibility issues including an unlabeled renew checkbox, unlabeled textarea in the add note modal, and empty headings rendered before JavaScript population. Test plan: 1. Have a user with checkouts 2. Log into the OPAC and go to "Summary" 3. Notice the renew checkbox does not have a corresponding label 4. Apply the patch 5. Repeat steps 1-2 6. Confirm the renew checkbox now has a corresponding label Additional accessibility fixes: 7. Open the "Report a problem" modal 8. Confirm the note textarea has a corresponding label 9. Confirm addNoteTitle and suspendHoldTitle are not exposed as empty headings 10. Run an accessibility checker and confirm the related errors are resolved 11. Sign off and have a great day! :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42231 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42231 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes some release notes| |accessibility issues on the | |patron's OPAC summary | |section: Form elements must | |have labels. | | | |- Checked out "Renew" | |checkbox: adds a hidden | |label for screen readers | |- Add note pop-up window | |for "Report a problem" | |(when the | |AllowCheckoutNotes | | system preference is | |enabled): adds a hidden | |label for screen readers | | | |It also hides the item | |title on the report a | |problem and suspend hold | |pop-up windows. CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Just wanted to confirm that you intended to no longer show the item title on report a problem and suspend hold modals. Testing notes (using KTD): 1. Renew: - axe DevTools: Form elements must have labels - Lighthouse: Form elements do not have associated labels - Before: <input type="checkbox" name="issue" value="1"> - After: <label> <span class="visually-hidden">Select item to renew</span> <input type="checkbox" name="issue" value="1"> </label> 2. Report a problem: - Enable the AllowCheckoutNotes system preference - Now have "Report a problem" column with "Add note" button on Summary > Checked out table - axe DevTools: Form elements must have labels - Before the patch, the item title is displayed above the text box for the note - After the patch, the item title is not shown on the modal Before: <div class="modal-body" id="addNoteBody"> <h2 id="addNoteTitle">CGI programming with Perl / </h2> <input type="hidden" id="addNoteIssueId" name="issue_id" value="2"> <textarea name="note" id="addNote" rows="4"></textarea> <div class="hint">Your note will be shown to the librarian when the item is checked in.</div> </div> After: <div class="modal-body" id="addNoteBody"> <h2 id="addNoteTitle" hidden="">Programming Perl / </h2> <input type="hidden" id="addNoteIssueId" name="issue_id" value="1"> added--> <label for="addNote" class="visually-hidden">Note</label> <textarea name="note" id="addNote" rows="4"></textarea> <div class="hint">Your note will be shown to the librarian when the item is checked in.</div> </div> 3. Suspend holds: - Have a hold for the patron - Go to: Summary > Holds - Click "Suspend" for the hold - Before the patch, the item title is displayed in italics above the "Suspend until: [date picker]" - After the patch, the item title is not shown on the modal - axe DevTools: no problem reported - Before: <h2 id="suspendHoldTitle"><em>Intermediate Perl / </em></h2> - After: <h2 id="suspendHoldTitle" hidden=""><em>Intermediate Perl / </em></h2> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42231 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197135|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42231 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 200754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200754&action=edit Bug 42231: (QA follow-up) Show item title in note and suspend-hold modals The static 'hidden' attribute on #addNoteTitle and #suspendHoldTitle was never removed, so the item title was populated but stayed invisible. - Toggle 'hidden' off when a modal is populated with a title - Toggle 'hidden' on when a modal is closed/cleared Test plan: - Enable AllowCheckoutNotes - OPAC > Summary > Checked out: click 'Add note', confirm the item title shows - OPAC > Summary > Holds: click 'Suspend', confirm the item title shows - Reopen each modal on a different item, confirm the title updates - Run an accessibility checker, confirm no empty-heading errors return Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42231 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.