https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think both would be better, but the second option is probably easiest for not so experienced translators. Moving around the %s is not so often done I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105309&action=edit Bug 25443: Improve translation of 'Select the record to link%s to' Before this patch the title was set in italic, which caused the translation string to be cut off. Removing the italic formatting in favor of quotes and splitting the string into 2 sentences (dealing with title existing and not existing: Select the host record to link to '[% bibliotitle | html %]' Select the host record to link To test: - Activate EasyAnalyticalRecords system preference - Search for a record in staff - Use Edit > Link to host record - Verify the text is shown as above with the reord's title - The second case is a bit theoretical: - Delete 245$a from the record or empty out biblio.title using SQL - Verify the string still shows but without the 'to...' part. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- In that case, will you consider (In reply to Katrin Fischer from comment #2)

I think both would be better, but the second option is probably easiest for not so experienced translators. Moving around the %s is not so often done I think.

Ok :) In that case, could you consider surrounding the text with <span>...</span>? If not we get this string "%s Select the host record to link to '%s' %s Select the host record to link %s " With span we get msgid "Select the host record to link" msgid "Select the host record to link to '%s'" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105309|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 105315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105315&action=edit Bug 25443: Improve translation of 'Select the record to link%s to' Before this patch the title was set in italic, which caused the translation string to be cut off. Removing the italic formatting in favor of quotes and splitting the string into 2 sentences (dealing with title existing and not existing: Select the host record to link to '[% bibliotitle | html %]' Select the host record to link To test: - Activate EasyAnalyticalRecords system preference - Search for a record in staff - Use Edit > Link to host record - Verify the text is shown as above with the reord's title - The second case is a bit theoretical: - Delete 245$a from the record or empty out biblio.title using SQL - Verify the string still shows but without the 'to...' part. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Patch works, added follow-up to put strings inside "span". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105315|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 106517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106517&action=edit Bug 25443: Improve translation of 'Select the record to link%s to' Before this patch the title was set in italic, which caused the translation string to be cut off. Removing the italic formatting in favor of quotes and splitting the string into 2 sentences (dealing with title existing and not existing: Select the host record to link to '[% bibliotitle | html %]' Select the host record to link To test: - Activate EasyAnalyticalRecords system preference - Search for a record in staff - Use Edit > Link to host record - Verify the text is shown as above with the reord's title - The second case is a bit theoretical: - Delete 245$a from the record or empty out biblio.title using SQL - Verify the string still shows but without the 'to...' part. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Enhancement, not backported to 19.05.x. It's likely that the new strings won't be translated for oldoldstable at this point of the cycle for all but the few most actively translated languages. So that might actually be a translation regression even for languages that are almost fully translated. All that is just guesswork though. -- You are receiving this mail because: You are watching all bug changes.