https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108811&action=edit Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108811|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108828&action=edit Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- prove t/db_dependent/XISBN.t passes with the patch, not sure what else to test? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108828|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108874&action=edit Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #7)

Use of uninitialized value $biblionumber in string ne at /usr/share/koha/C4/XISBN.pm line 111.

It appeared before this patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #10)

(In reply to Jonathan Druart from comment #8)

...

Pushed to master for 20.11, thanks to everybody involved!

Ok, no need to look further here ;)

I wanted to fix the failing test, but I think it would be good to confirm the hypothesis. I did not manage to validate it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 19.11.10 released in| | --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 19.11.10 |20.11.00, 20.05.04, released in| |19.11.10 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.04, |20.11.00, 20.05.04, released in|19.11.10 |19.11.10, 19.05.15 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes.