[Bug 32747] New: OPAC detail page explodes for items without itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Bug ID: 32747 Summary: OPAC detail page explodes for items without itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When there is an item without itemtype the OPAC detail page explodes: Error trace Can't call method "itemtype" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl line 713 I know we agreed not to fix this everywhere, but I think there is definitely a need to fix it in this very spot, because it's on a main page in the OPAC. One thing that can cause this: We just very recently made itemtype mandatory on the acq item form. On order items often had no itemtypes in the past and it was not a problem. Libraries would assign the itemtype on delivery/receive, avoiding any issues in circulation. There might be quite a lot of those 'in the wild'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Closely related to Bug 21842 that has been closed with wont fix. I'd be happy to reopen it ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21842 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not that close... we agreed on not always checking - but this is the end user exploding pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #2)
Not that close... we agreed on not always checking - but this is the end user exploding pages.
Indeed, OPAC should be bulletproof ^^ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is caused by data inconsistencies, there is a script to catch them. We should not fix that IMO. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #3)
(In reply to Katrin Fischer from comment #2)
Not that close... we agreed on not always checking - but this is the end user exploding pages.
Indeed, OPAC should be bulletproof ^^
No, data should be correct. We provide a script that must be run when data is migrated. Then it's no longer possible to break it using the UI (unless you mess with the config). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Koha does only have a recent history of enforcing the itemtype as a mandatory field. We have tried to get libraries to fix things, but it's not an easy process. Especially as the acq form didn't have it mandatory until ... last release? The data inconsistencies script is fine for migrations, but libraries using Koha for a long while don't know about it. This is what I think, being a bit more lenient... but I guess you got a point too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.chalon@univ-lyon2.fr --- Comment #7 from David Cook <dcook@prosentient.com.au> --- *** Bug 33351 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Looks like Pierre Chalon is reproducing this out of the box on PTFS Europe and BibLibre's sandboxes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #8)
Looks like Pierre Chalon is reproducing this out of the box on PTFS Europe and BibLibre's sandboxes.
The bug is definitely confirmed and real. The problem is: should we fix it or not. Item type is no mandatory and Koha won't work correctly without it in a lot of places. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So: is this a WONTFIX? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Should the error be more graceful? To be more straightforward in making it known to librarians that some cataloguing work is needed on old data. So that they don't need to have their sysadmin/provider investigate the error (whose message is likely hidden in production) to know the cause. And/or a least add check in about.pl (it doesn't complain currently) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31538 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35896 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |WONTFIX --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We have other bugs to expose the data checks to librarians more easily.. I think those will help here and we can't easily code around incorrect data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org