https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This could also be useful for collection codes or itemtypes; this bug could be expanded to cover those or new bugs could be filed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 203671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203671&action=edit Bug 43299: Add classes to each tr for loc, ccode, and item type To test: 1/ APPLY PATCH 2/ Got to a record holding page and inscept the code for each row. 3/ You should now see classes for item type, collection code, and location. For example: <tr class="ccode_REF loc_GEN itype_BK"> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- I think this patch doesn't address the issue in this bug at all. This adds classes for item type, collection code and location to the row. The target is the status table data in the status column. Most of the statuses have a specific class, but cart does not, nor does available. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lisette Scheer from comment #5)

While I agree with Christopher that it's not fixing the issue, I disagree that it's the status column that should be fixed.

My understanding of the bug was not that the whole row would be labeled but that the shelving location itself would be:

<span class="shelvingloc">YA Shelves</span> would turn into <span class="shelvingloc loc_YA" >YA Shelves</span>

etc, though I supposed you could do css that looked at .shelvingloc that was a child of loc_YA, but it seems more complicated for the targeting.

+1 I think maybe Christopher had a different bug in mind? It would make sense, but this one is clearly about some other area. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add class to shelving |Add value-based class to |location column in staff |shelving location column in |interface in order to allow |staff interface in order to |styling |allow styling -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203671|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203784&action=edit Bug 43299: Add extra class about specific shelvingloc To test: 1/ APPLY PATCH 2/ Got to a record holding page and inspect the shevlingloc class. 3/ You should now also include a class for the specific shelving location Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 203790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203790&action=edit Bug 43299: Add extra class about specific shelvingloc To test: 1/ APPLY PATCH 2/ Got to a record holding page and inspect the shevlingloc class. 3/ You should now also include a class for the specific shelving location Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michelle Spinney <mspinney@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #10)

I'm sorry, but the title of this bug is referring to the column, not the row. What part of this am I not getting? I am confused. Andrew, is this the goal you had in mind?

My intent here was to replicate what you and George showed using jQuery for in your Terrific Every Other Thursday video -- adding a class to each cell in the shelving location column, with that class including the location code for the item. This is what the current patch here does -- if your item has the shelving location GEN, then the shelving location cell for that item will have the class loc_GEN and can be styled using that class. The previous patch instead put that class on the whole row. This also allowed styling of just the shelving location cell, but required slightly more complicated CSS to do so. (Conversely, the previous patch would have made it easier if one wanted to style the whole row based on the shelving location of the item.) The current patch does not do anything with the itype or ccode cells. It would be possible to achieve the same sort of result there, but requires a little more reworking of how those cells are constructed. -- You are receiving this mail because: You are watching all bug changes.