[Bug 40879] New: Add system preference to enable/disable the “Cite” option in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Bug ID: 40879 Summary: Add system preference to enable/disable the “Cite” option in the OPAC Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The OPAC “Cite” option currently appears by default with no way to toggle it. Staff have requested a system preference that would allow libraries to enable or disable the display of the “Cite” link, or hide it entirely when not needed. This would give libraries greater control over OPAC features and better align with local citation practices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186928&action=edit Bug 40879: New syspref for enabling and disabling Cite in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186929&action=edit Bug 40879: Added system preference to sysprefs.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186930&action=edit Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186931&action=edit Bug 40879: Added syspref to catalog_cite.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186932&action=edit Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186928|0 |1 is obsolete| | --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186933&action=edit Bug 40879: New OpacCiteModal system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186929|0 |1 is obsolete| | Attachment #186933|0 |1 is obsolete| | --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186935&action=edit Bug 40879: Added system preference to sysprefs.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186936&action=edit Bug 40879: Added OpacCiteModal system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186930|0 |1 is obsolete| | Attachment #186931|0 |1 is obsolete| | Attachment #186932|0 |1 is obsolete| | Attachment #186935|0 |1 is obsolete| | Attachment #186936|0 |1 is obsolete| | --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186937&action=edit Bug 40879: Added syspref to catalog_cite.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186938&action=edit Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186939&action=edit Bug 40879: Added system preference to sysprefs.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186940&action=edit Bug 40879: Added OpacCiteModal system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186941&action=edit Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186937|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 190032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190032&action=edit Bug 40879: Added syspref to catalog_cite.inc Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186938|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 190033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190033&action=edit Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186939|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 190034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190034&action=edit Bug 40879: Added system preference to sysprefs.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186940|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 190035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190035&action=edit Bug 40879: Added OpacCiteModal system preference Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186941|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 190036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190036&action=edit Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement adds a new release notes| |system preference, | |OpacCiteModal, to control | |the display of the 'Cite' | |option on OPAC | |bibliographic detail pages. --- Comment #19 from David Nind <david@davidnind.com> --- This is nice enhancement. Testing notes (using KTD): 1. The Cite option is shown by default in the OPAC, which I think is the correct approach. As it is currently on by default (and no way to turn it off), the leaving it as shown is preferred, I think. (The test plan says it is not shown by deafult.) Other observations: 1. I think a better name for the system preference is OPACCite, rather than with 'Modal' (which is more a developer term), and put OPAC in capitals (we have a lot of inconsistency here though!). 2. Suggested options and description for the new system preference: [Show/Don't show] the cite option on OPAC bibliographic detail pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #20 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to David Nind from comment #19)
This is nice enhancement.
Testing notes (using KTD):
1. The Cite option is shown by default in the OPAC, which I think is the correct approach. As it is currently on by default (and no way to turn it off), the leaving it as shown is preferred, I think. (The test plan says it is not shown by deafult.)
Other observations:
1. I think a better name for the system preference is OPACCite, rather than with 'Modal' (which is more a developer term), and put OPAC in capitals (we have a lot of inconsistency here though!).
2. Suggested options and description for the new system preference: [Show/Don't show] the cite option on OPAC bibliographic detail pages.
The patch still applies and works. I second David's comments. Failing QA so we can get a follow-up with the suggested changes (sorry Laura!). I can try my hand at making a follow-up if necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #21 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 190065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190065&action=edit Bug 40879: follow-up (change OpacCiteModal to OPACCite) This patch addresses QA comments on the new system preference name and description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #22 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Crossing my fingers I didn't mess everything up with my yellow belt git-fu skillzzz. I tried to commit a follow up addressing David's comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a new |This enhancement adds a new release notes|system preference, |system preference, |OpacCiteModal, to control |OPACCite, to control the |the display of the 'Cite' |display of the 'Cite' |option on OPAC |option on OPAC |bibliographic detail pages. |bibliographic detail pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190032|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 190087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190087&action=edit Bug 40879: Added syspref to catalog_cite.inc Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190033|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 190088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190088&action=edit Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190034|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 190089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190089&action=edit Bug 40879: Added system preference to sysprefs.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190035|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 190090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190090&action=edit Bug 40879: Added OpacCiteModal system preference Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190036|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 190091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190091&action=edit Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190065|0 |1 is obsolete| | --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 190092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190092&action=edit Bug 40879: follow-up (change OpacCiteModal to OPACCite) This patch addresses QA comments on the new system preference name and description. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #29 from David Nind <david@davidnind.com> --- (In reply to Caroline Cyr La Rose from comment #22)
Crossing my fingers I didn't mess everything up with my yellow belt git-fu skillzzz. I tried to commit a follow up addressing David's comments.
Thanks Caroline! Everything seemed to work as expected - have added my sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14670 --- Comment #30 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Linking to the original enhancement to make it easier to find. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 [Bug 14670] Add 'cite' option to detail page in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl --- Comment #31 from Roman Dolny <roman.dolny@jezuici.pl> --- When disabling "Cite" feature in detail views, shouldn't we also disable the preparation of data for it? $template->param( cites => C4::Record::marc2cites($record) ); in: opac-detail.pl, opac-ISBDdetail.pl, opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Roman Dolny from comment #31)
When disabling "Cite" feature in detail views, shouldn't we also disable the preparation of data for it?
$template->param( cites => C4::Record::marc2cites($record) ); in: opac-detail.pl, opac-ISBDdetail.pl, opac-MARCdetail.pl
Yes, I agree with Roman. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39461 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Julie <julie@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julie@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #33 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- I’m preparing a follow-up patch to only generate cite data when OPACCite is enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #34 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 194902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194902&action=edit Bug 40879: Only prepare cites data when OPACCite is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #35 from David Nind <david@davidnind.com> --- Getting sha1/fake ancestor errors when trying to apply the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #36 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to David Nind from comment #35)
Getting sha1/fake ancestor errors when trying to apply the patches.
I'm able to apply the patches (I do get auto-merging messages, but they resolve themselves). David, would you mind trying again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190087|0 |1 is obsolete| | --- Comment #37 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 195185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195185&action=edit Bug 40879: Added syspref to catalog_cite.inc Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190088|0 |1 is obsolete| | --- Comment #38 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 195186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195186&action=edit Bug 40879: Added syspref to opac-detail-sidebar.inc 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OpacCiteModal. It is currently set to Disable. 3. Go to the Opac and ensure that the Cite feature is not displaying in the detailed bibliographic record. 4. Now go to the System Preferences and Enable OpacCiteModal. 5. Go back to the Opac and ensure that the Cite feature is displaying correctly again in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 6. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190089|0 |1 is obsolete| | --- Comment #39 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 195187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195187&action=edit Bug 40879: Added system preference to sysprefs.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190090|0 |1 is obsolete| | --- Comment #40 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 195188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195188&action=edit Bug 40879: Added OpacCiteModal system preference Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190091|0 |1 is obsolete| | --- Comment #41 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 195189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195189&action=edit Bug 40879: Added new OpacCiteModal system preference to the admin opac sysprefs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190092|0 |1 is obsolete| | --- Comment #42 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 195190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195190&action=edit Bug 40879: follow-up (change OpacCiteModal to OPACCite) This patch addresses QA comments on the new system preference name and description. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194902|0 |1 is obsolete| | --- Comment #43 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 195191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195191&action=edit Bug 40879: Only prepare cites data when OPACCite is enabled Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #44 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- OK I was able to apply the patches and test. I signed off. I hope that's ok even though I contributed a small change. I didn't know how to update the test plan in the commit message when there are multiple patches, but here is the updated test plan if someone is able to change it : 1. Apply the patch. Use updatedatabase and restart_all 2. Go to System Preferences and search for OPACCite. It is currently set to Show. --> Check the syspref name and description to make sure it's written correctly 3. Go to the OPAC and ensure that the Cite feature is displaying in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 4. Disable OPACCite. 5. Go back to the Opac and ensure that the Cite feature is NOT displayed correctly again in the detailed bibliographic record. 6. Sign off and have a great day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #45 from David Nind <david@davidnind.com> --- Created attachment 195204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195204&action=edit Bug 40879: Added system preference to catalog_cite.inc Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #46 from David Nind <david@davidnind.com> --- Created attachment 195205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195205&action=edit Bug 40879: Added system preference to opac-detail-sidebar.inc 1. Apply the patch. Update the database (updatedatabase) and restart everything (restart_all). 2. Go to Administration > System preferences, and search for OPACCite. It is set to 'Enable' by default. --> Check the system preference name and description to make sure it's written correctly 3. Go to the OPAC and ensure that the Cite feature is displaying in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 4. Set the OPACCite system preference to 'Disable'. 5. Go back to the OPAC and ensure that the Cite feature is NOT displayed in the detailed bibliographic record. 6. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195187|0 |1 is obsolete| | --- Comment #47 from David Nind <david@davidnind.com> --- Created attachment 195206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195206&action=edit Bug 40879: Added system preference to sysprefs.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195188|0 |1 is obsolete| | --- Comment #48 from David Nind <david@davidnind.com> --- Created attachment 195207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195207&action=edit Bug 40879: Added OpacCiteModal system preference Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #49 from David Nind <david@davidnind.com> --- Created attachment 195208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195208&action=edit Bug 40879: Added new OpacCiteModal system preference to the OPAC section Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #50 from David Nind <david@davidnind.com> --- Created attachment 195209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195209&action=edit Bug 40879: (follow-up) Change OpacCiteModal to OPACCite This patch addresses QA comments on the new system preference name and description. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #51 from David Nind <david@davidnind.com> --- Created attachment 195210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195210&action=edit Bug 40879: Only prepare cite data when OPACCite is enabled Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195204|0 |1 is obsolete| | --- Comment #52 from David Nind <david@davidnind.com> --- Created attachment 195211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195211&action=edit Bug 40879: Added system preference to catalog_cite.inc Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195205|0 |1 is obsolete| | --- Comment #53 from David Nind <david@davidnind.com> --- Created attachment 195212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195212&action=edit Bug 40879: Added system preference to opac-detail-sidebar.inc 1. Apply the patch. Update the database (updatedatabase) and restart everything (restart_all). 2. Go to Administration > System preferences, and search for OPACCite. It is set to 'Show' by default. --> Check the system preference name and description to make sure it's written correctly 3. Go to the OPAC and ensure that the Cite feature is displaying in the detailed bibliographic record. Please also ensure that the Cite modal works as originally designed. 4. Set the OPACCite system preference to 'Don't show'. 5. Go back to the OPAC and ensure that the Cite feature is NOT displayed in the detailed bibliographic record. 6. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195206|0 |1 is obsolete| | --- Comment #54 from David Nind <david@davidnind.com> --- Created attachment 195213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195213&action=edit Bug 40879: Added system preference to sysprefs.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195207|0 |1 is obsolete| | --- Comment #55 from David Nind <david@davidnind.com> --- Created attachment 195214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195214&action=edit Bug 40879: Added OpacCiteModal system preference Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195208|0 |1 is obsolete| | --- Comment #56 from David Nind <david@davidnind.com> --- Created attachment 195215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195215&action=edit Bug 40879: Added new OpacCiteModal system preference to the OPAC section Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195209|0 |1 is obsolete| | --- Comment #57 from David Nind <david@davidnind.com> --- Created attachment 195216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195216&action=edit Bug 40879: (follow-up) Change OpacCiteModal to OPACCite This patch addresses QA comments on the new system preference name and description. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195210|0 |1 is obsolete| | --- Comment #58 from David Nind <david@davidnind.com> --- Created attachment 195217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195217&action=edit Bug 40879: Only prepare cite data when OPACCite is enabled Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #59 from David Nind <david@davidnind.com> --- (In reply to Caroline Cyr La Rose from comment #44)
OK I was able to apply the patches and test. I signed off. I hope that's ok even though I contributed a small change.
I didn't know how to update the test plan in the commit message when there are multiple patches, but here is the updated test plan if someone is able to change it :
....
I was able to get the patches to apply as well - maybe I hadn't reset things properly when I tried to test earlier. I reworded the commit messages using: git rebase -i HEAD~X - where X = the number of patches to go back (in this case 7) - change pick to reword in the file with the list of patches that is opened after you enter the rebase command - you then get to edit each commit message you've selected I retested as well, and everything works as per the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 --- Comment #60 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to David Nind from comment #59)
(In reply to Caroline Cyr La Rose from comment #44)
OK I was able to apply the patches and test. I signed off. I hope that's ok even though I contributed a small change.
I didn't know how to update the test plan in the commit message when there are multiple patches, but here is the updated test plan if someone is able to change it :
....
I was able to get the patches to apply as well - maybe I hadn't reset things properly when I tried to test earlier.
I reworded the commit messages using: git rebase -i HEAD~X
- where X = the number of patches to go back (in this case 7) - change pick to reword in the file with the list of patches that is opened after you enter the rebase command - you then get to edit each commit message you've selected
I retested as well, and everything works as per the test plan.
Thanks David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40879 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org