[Bug 11551] New: Allow to search on ordernumber in histsearch.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Bug ID: 11551 Summary: Allow to search on ordernumber in histsearch.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org The orders search does not allow to search on the ordernumber. On the way, the parent ordernumber could be requested too in order to display the 'children' for a given order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24278&action=edit Bug 11507: Allow to search on parent ordernumber in histsearch.pl It is now possible to search on the ordernumber on the order search page. Also search on parent_ordernumber is possible. Like that, you are allow to search children for a given ordernumber. Test plan: 1/ create a basket and 1 order with at least 2 items. 2/ receive partialy the order (receive only 1 item). 3/ note that a new ordernumber is created for item not received. 4/ go on the order search form and search for the original ordernumber without checking the new checkbox "Display children too." => only 1 order (the parent) is displayed. 5/ now check the checkbox and search again => the parent order is displayed but children too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24279&action=edit Bug 11551: Add unit tests for GetHistory prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24278|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24280&action=edit Bug 11551: Allow to search on parent ordernumber in histsearch.pl It is now possible to search on the ordernumber on the order search page. Also search on parent_ordernumber is possible. Like that, you are allow to search children for a given ordernumber. Test plan: 1/ create a basket and 1 order with at least 2 items. 2/ receive partialy the order (receive only 1 item). 3/ note that a new ordernumber is created for item not received. 4/ go on the order search form and search for the original ordernumber without checking the new checkbox "Display children too." => only 1 order (the parent) is displayed. 5/ now check the checkbox and search again => the parent order is displayed but children too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 AlexHorsman <dhorsman@xtra.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dhorsman@xtra.co.nz --- Comment #4 from AlexHorsman <dhorsman@xtra.co.nz> --- trying to test this: prove t/db_dependent/Acquisition.t but getting this error: t/db_dependent/Acquisition.t .. 1/66 Use of uninitialized value $orderstatus in string ne at /usr/share/koha/lib/C4/Acquisition.pm line 2242. # Failed test 'GetHistory with a given ordernumber returns 1 order' # at t/db_dependent/Acquisition.t line 184. # got: '4' # expected: '1' Use of uninitialized value $orderstatus in string ne at /usr/share/koha/lib/C4/Acquisition.pm line 2242. # Failed test 'GetHistory with a given ordernumber and search_children_too set returns 2 orders' # at t/db_dependent/Acquisition.t line 186. # got: '4' # expected: '2' # Looks like you failed 2 tests of 66. t/db_dependent/Acquisition.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/66 subtests Test Summary Report ------------------- t/db_dependent/Acquisition.t (Wstat: 512 Tests: 66 Failed: 2) Failed tests: 56-57 Non-zero exit status: 2 Files=1, Tests=66, 1 wallclock secs ( 0.06 usr 0.00 sys + 0.94 cusr 0.07 csys = 1.07 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to AlexHorsman from comment #4)
trying to test this: prove t/db_dependent/Acquisition.t
but getting this error:
Did you apply the 2 patches against master? The tests pass for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by remy juliette <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26141&action=edit Bug 11551: Add unit tests for GetHistory prove t/db_dependent/Acquisition.t should return green. Signed-off-by: remy juliette <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26142&action=edit Bug 11551: Allow to search on parent ordernumber in histsearch.pl It is now possible to search on the ordernumber on the order search page. Also search on parent_ordernumber is possible. Like that, you are allow to search children for a given ordernumber. Test plan: 1/ create a basket and 1 order with at least 2 items. 2/ receive partialy the order (receive only 1 item). 3/ note that a new ordernumber is created for item not received. 4/ go on the order search form and search for the original ordernumber without checking the new checkbox "Display children too." => only 1 order (the parent) is displayed. 5/ now check the checkbox and search again => the parent order is displayed but children too. Signed-off-by: remy juliette <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Jonathan, it's Acquisition.t again - could you take a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26141|0 |1 is obsolete| | Attachment #26142|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26249&action=edit Bug 11551: Add unit tests for GetHistory prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26250&action=edit Bug 11551: Allow to search on parent ordernumber in histsearch.pl It is now possible to search on the ordernumber on the order search page. Also search on parent_ordernumber is possible. Like that, you are allow to search children for a given ordernumber. Test plan: 1/ create a basket and 1 order with at least 2 items. 2/ receive partialy the order (receive only 1 item). 3/ note that a new ordernumber is created for item not received. 4/ go on the order search form and search for the original ordernumber without checking the new checkbox "Display children too." => only 1 order (the parent) is displayed. 5/ now check the checkbox and search again => the parent order is displayed but children too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26249|0 |1 is obsolete| | Attachment #26250|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26281&action=edit [PASSED QA] Bug 11551: Add unit tests for GetHistory prove t/db_dependent/Acquisition.t should return green. Signed-off-by: remy juliette <juliette.levast@iepg.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26282&action=edit [PASSED QA] Bug 11551: Allow to search on parent ordernumber in histsearch.pl It is now possible to search on the ordernumber on the order search page. Also search on parent_ordernumber is possible. Like that, you are allow to search children for a given ordernumber. Test plan: 1/ create a basket and 1 order with at least 2 items. 2/ receive partialy the order (receive only 1 item). 3/ note that a new ordernumber is created for item not received. 4/ go on the order search form and search for the original ordernumber without checking the new checkbox "Display children too." => only 1 order (the parent) is displayed. 5/ now check the checkbox and search again => the parent order is displayed but children too. Signed-off-by: remy juliette <juliette.levast@iepg.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan and Julian! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolyn.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #15 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Does not apply easily to 3.14.x so I set as resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org