[Bug 9288] New: Add a script to test SIP from the command line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Bug ID: 9288 Summary: Add a script to test SIP from the command line Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com CC: colin.campbell@ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14146&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14146|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14147&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14147|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14148&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14148|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14149&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14149|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14150&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14150|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14635&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14635|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14640&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat@biblibre.com --- Comment #8 from Adrien SAURAT <adrien.saurat@biblibre.com> --- I tried the script and managed to have a successfull connection. An interactive script simulating a self checkout machine will indeed be very useful! Still, I have a few remarks : 1/ I had to manually set the file as executable, the patch should include the exec permission. 2/ At firt, I executed the script without argument, this results in an error message, it would be nice to have a little help display (like with cleanup_database.pl for example). 3/ If a help text is included, maybe should it also be related to the -h and --help options? But that would mean changing the --host parameter (maybe it could become -a --address?) The 1st point seems mandatory to me for a sign off, I'd sign without pts 2 and 3 being included but it could give a better consistency to our scripts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #9 from Adrien SAURAT <adrien.saurat@biblibre.com> --- It may be good also to give this script a more explicit name. Something like "sip_sc_emulator.pl" or anything explaining exactly what it is intented to be. Saying this because I developped a small testing script too. They won't do the same thing so we may end up using both of them. The script I'm working on will simply send/receive SIP messages based on a list of commands stored in a text file. Useful when I want to quickly test several time the same command chain. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14640|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18203&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18203|0 |1 is obsolete| | --- Comment #11 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 18268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18268&action=edit Bug 9288 - Add a script to test SIP from the command line Tested OK for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18268|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19106&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. Signed-off-by: Adrien Saurat <adrien.saurat@biblibre.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- This looks like this could become the core of a Nagios check for the SIP server. However, it doesn't work for me, as it hangs after sending the 93 login message, never receiving the response. I tested with both an Evergreen SIP server and a Koha one. Tacking on the following line will probably make it work: $/ = "\r"; However, since not all SIP devices agree on the terminator character, even better would be to use something other than <$socket> to fetch from the socket. Also, this patch would introduce new code that violates PERL2: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL2:_Modern::Perl. While perhaps a little laxity on the coding guidelines might be OK for test code, I'm drawing a firm line in the sand regarding PERL2: all new code *must* have strictures and warnings enabled. Or be accompanied by a note signed by Larry Wall _and_ Damien Conway explaining in detail why strictures and warnings should be turned off. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19476&action=edit Bug 9288 - Add a script to test SIP from the command line - QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Galen, is this what you are looking for? I have no idea why strictures weren't enabled, my bad! I've also made the message terminator configurable from the command line, defaulting to CRLF. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, i am trying to figure out SIP right now and was hoping to use your script. But I am running into problems - with your follow up, it looks like this: patron admin --password admin main::help() called too early to check prototype at ./sip_cli_emulator.pl line 46. Use of uninitialized value $terminator in string eq at ./sip_cli_emulator.pl line 50. OUTBOUND: 9300CNsip|COsip|CPMPL| Use of uninitialized value $data in concatenation (.) or string at ./sip_cli_emulator.pl line 69. INBOUND: Use of uninitialized value $data in pattern match (m//) at ./sip_cli_emulator.pl line 71. Login Failed! Without, the warns are gone, but my login still fails? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Katrin, it looks like the full set of parameters you passed to the script didn't get pasted in correctly. Can you please repost your parameters? Kyle -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, I see. I used the same paraemters with and without the follow up - one time with errors, the other now. I had all parameters in the sequence suggested and always the long form -- as the short form seemed to give me some trouble. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, could you give an example on how to call the script that works for you? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Setting to failed to get Kyle's attention to comment#18 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Try it like this: misc/sip_cli_emulator.pl --address my.library.org --port 6001 --sip_user my_sip_user --sip_pass MyPassw0rd --location MPL --patron kylemhall --password letmein --terminator CRLF -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21278&action=edit Bug 9288 - Add a script to test SIP from the command line - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, it works now - using this line: misc/sip_cli_emulator.pl --a localhost --port 6001 --sip_user xxx --sip_pass xxx --location CPL --patron xxx --password xxx But I see 2 warnings, could you please fix those? main::help() called too early to check prototype at misc/sip_cli_emulator.pl line 46. Use of uninitialized value $terminator in string eq at misc/sip_cli_emulator.pl line 50. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22286&action=edit Bug 9288 - Add a script to test SIP from the command line - QA Followup 3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19106|0 |1 is obsolete| | Attachment #19476|0 |1 is obsolete| | Attachment #21278|0 |1 is obsolete| | Attachment #22286|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22443&action=edit [PASSED QA] Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. Signed-off-by: Adrien Saurat <adrien.saurat@biblibre.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22444&action=edit [PASSED QA] Bug 9288 - Add a script to test SIP from the command line - QA Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22445&action=edit [PASSED QA] Bug 9288 - Add a script to test SIP from the command line - QA Followup 2 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22446&action=edit [PASSED QA] Bug 9288 - Add a script to test SIP from the command line - QA Followup 3 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Works now ok for me, no more warnings. Started SIP server and used: misc/sip_cli_emulator.pl --a 127.0.0.1 --port 6001 --sip_user sip --sip_pass sip --location MPL --patron sip --password sip -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Kyle, I missed this from the QA script: FAIL misc/sip_cli_emulator.pl OK pod OK forbidden patterns OK valid FAIL critic Subroutine prototypes used at line 115, column 1. See page 194 of PBP. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- That's odd. I'm not getting that fail! 08:01 ~/kohaclone (bug9288-qa $% u+4)$ koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 4d3558a 'Bug 9288 - Add a script to test SIP f') OK misc/sip_cli_emulator.pl OK pod OK forbidden patterns OK valid 0 OK critic (In reply to Katrin Fischer from comment #30)
Sorry Kyle, I missed this from the QA script:
FAIL misc/sip_cli_emulator.pl OK pod OK forbidden patterns OK valid FAIL critic Subroutine prototypes used at line 115, column 1. See page 194 of PBP.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I reran the test, the result is the same: testing 4 commit(s) (applied to e815131 'Bug 10138: (follow-up) FIX sql errors') FAIL misc/sip_cli_emulator.pl OK pod OK forbidden patterns OK valid FAIL critic Subroutine prototypes used at line 115, column 1. See page 194 of PBP. Maybe someone else can test - did you check line 115? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23873&action=edit Bug 9288 - Add a script to test SIP from the command line - QA Followup 4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Setting to passed qa on the assumption that this was the only remaining issue. If I am wrong please update the status! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The QA script passes now for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. You may be amused to hear that I tested it successfully with an Evergreen SIP server. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #37 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #39 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- This is very cool! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org