[Bug 43383] New: problem adding to list or cart when using browser's back button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Bug ID: 43383 Summary: problem adding to list or cart when using browser's back button Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- To recreate: 1. Do a catalog search that brings up multiple results 2. Check the checkbox of in the left column for the first two results 3. Click on the title of the 3rd result to take you to the details page for that item 4. Use the borwser's back button to return to the search results 5. Notice the first 2 titles are still checked. 6. Now check the 3rd result and click 'Add to list' 7. Only the 3rd title is added, even though all 3 are checked. 8. Try steps 1 - 7 again but with 'Add to cart', same behavior. 9. Try setps 1 - 7 again but with 'Place hold', all 3 items are selected. I get this behavior in both Chrome and Firefox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 204231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204231&action=edit Bug 43383: Use checkbox status of :checked when doing cartsubmit or listsubmit To test: 1. Do a catalog search that brings up multiple results 2. Check the checkbox of in the left column for the first two results 3. Click on the title of the 3rd result to take you to the details page for that item 4. Use the borwser's back button to return to the search results 5. Notice the first 2 titles are still checked. 6. Now check the 3rd result and click 'Add to list' 7. Only the 3rd title is added, even though all 3 are checked. 8. Try steps 1 - 7 again but with 'Add to cart', same behavior. 9. Try setps 1 - 7 again but with 'Place hold', all 3 items are selected. 10. APPLY PATCH, clear browser cache and run through all the steps again. This time your selction should be rememebered. Bonus points for trying in as many browsers as possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu --- Comment #2 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Hi Lucas, I was going to test on this, but I couldn't actually see the wrong behavior in any of the three browsers I have on my machine. I wonder if the problem perhaps cleared itself up with subsequent browser updates? (I saw this happen on my own bug recently #43153). I could not confirm the original problematic behavior on: * Edge 152.0.4191.62 (Official build) (64-bit) * Chrome Version 152.0.7977.83 (Official Build) (64-bit) * Firefox Version 155.0.1 (64-bit) Following your steps WITHOUT PATCH all 3 selected items reached the cart or list successfully in these browser versions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 --- Comment #3 from Bastien Chauvet <bastien.chauvet@inlibro.com> --- Created attachment 205093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205093&action=edit Bug 43383: Use checkbox status of :checked when doing cartsubmit or listsubmit To test: 1. Do a catalog search that brings up multiple results 2. Check the checkbox of in the left column for the first two results 3. Click on the title of the 3rd result to take you to the details page for that item 4. Use the borwser's back button to return to the search results 5. Notice the first 2 titles are still checked. 6. Now check the 3rd result and click 'Add to list' 7. Only the 3rd title is added, even though all 3 are checked. 8. Try steps 1 - 7 again but with 'Add to cart', same behavior. 9. Try setps 1 - 7 again but with 'Place hold', all 3 items are selected. 10. APPLY PATCH, clear browser cache and run through all the steps again. This time your selction should be rememebered. Bonus points for trying in as many browsers as possible. Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bastien.chauvet@inlibro.com --- Comment #4 from Bastien Chauvet <bastien.chauvet@inlibro.com> --- (In reply to Gretchen Maxeiner from comment #2)
Hi Lucas, I was going to test on this, but I couldn't actually see the wrong behavior in any of the three browsers I have on my machine. I wonder if the problem perhaps cleared itself up with subsequent browser updates? (I saw this happen on my own bug recently #43153).
I could not confirm the original problematic behavior on: * Edge 152.0.4191.62 (Official build) (64-bit) * Chrome Version 152.0.7977.83 (Official Build) (64-bit) * Firefox Version 155.0.1 (64-bit)
Following your steps WITHOUT PATCH all 3 selected items reached the cart or list successfully in these browser versions.
Hi Gretchen! I actually managed to replicate the wrong behaviour, but it was only occurring on the intranet, on both Chrome and Firefox. As you mentioned, it was already working as intended on OPAC. Those were my browser versions : - Chrome Version 152.0.7977.82 (Official Build) (64-bit) - Firefox Version 155.0.1 (64-bit) I then applid the patch from Lucas, and it worked perfectly, which is the reason I signed this off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|problem adding to list or |Problem adding to a list or |cart when using browser's |cart when using browser's |back button |back button CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 --- Comment #5 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Good catch, Bastien! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|david@davidnind.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- This works as described. The functions vShelfAdd and addMultiple take a jQuery array of checkboxes, following the similar pattern as in shelves.tt lines 965 and 984. Nice work, Passing QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205093|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206270&action=edit Bug 43383: Use checkbox status of :checked when doing cartsubmit or listsubmit To test: 1. Do a catalog search that brings up multiple results 2. Check the checkbox of in the left column for the first two results 3. Click on the title of the 3rd result to take you to the details page for that item 4. Use the borwser's back button to return to the search results 5. Notice the first 2 titles are still checked. 6. Now check the 3rd result and click 'Add to list' 7. Only the 3rd title is added, even though all 3 are checked. 8. Try steps 1 - 7 again but with 'Add to cart', same behavior. 9. Try setps 1 - 7 again but with 'Place hold', all 3 items are selected. 10. APPLY PATCH, clear browser cache and run through all the steps again. This time your selction should be rememebered. Bonus points for trying in as many browsers as possible. Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43383 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org