[Bug 9430] New: Use DataTables on library transfer limits page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Bug ID: 9430 Summary: Use DataTables on library transfer limits page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The library transfer limits page uses the old tablesorter plugin. It should be replaced with the DataTables plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14713&action=edit Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14713|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14749&action=edit Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14749|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14882&action=edit Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14882|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15693&action=edit Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15693|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15739&action=edit [SIGNED-OFF] Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch replaces tablesorter with datatable on the branch transfer limits page. A little ergonomic issue: the table in the first tab has not the same width as others (the "min-width: 50%;" is not adequate). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15739|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15880&action=edit Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables + delete an unused div block (used for pager) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org