https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171925&action=edit Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171925|0 |1 is obsolete| | --- Comment #2 from Olivier V <ovezina@inlibro.com> --- Created attachment 171978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171978&action=edit Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.) Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Remember user's table state for all tables (Generalise table saveState for all tables) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 23.11.x maybe because of Bug 33568 -- You are receiving this mail because: You are watching all bug changes.