https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37562 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170011&action=edit Bug 37562: Add patron title to duplicate patron warning and don't show popup if cannot see patron This patch passes the suspected duplicate to the template and uses patron title to display very brief info. If the user cannot view the patron there is no longer a link tot he brief popup and they will only see 'A patron from library X" There is a FIXME asking if we should use search_limited - I believe we should check all branches, so the staff can ask the patron if they have an exising account in a consortium depending on rules about multiple cards To test: 1 - Edit a user to grant catalogue and all borrower permissions except 'view_borrower_infos_from_any_libraries' 2 - Find a patron from a different library and note surname and firstname 3 - Login as the patron above 4 - Enter a new patron with the same surname and firstname 5 - See the 'Duplicate patron' warning 6 - Click to view the patron 7 - No info is listed 8 - Apply patch 9 - Reload and resubmit - or fill out form again 10 - Note that you see 'A patron from library XXX' and no popup link 11 - Add view_borrower_infos_from_any_libraries to the staff 12 - Repeat the duplication and confirm the warning now has patron name and the popup link is visible and works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37562 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37562 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170020|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 170323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170323&action=edit Bug 37562: Add patron title to duplicate patron warning and don't show popup if cannot see patron This patch passes the suspected duplicate to the template and uses patron title to display very brief info. If the user cannot view the patron there is no longer a link tot he brief popup and they will only see 'A patron from library X" There is a FIXME asking if we should use search_limited - I believe we should check all branches, so the staff can ask the patron if they have an exising account in a consortium depending on rules about multiple cards To test: 1 - Edit a user to grant catalogue and all borrower permissions except 'view_borrower_infos_from_any_libraries' 2 - Find a patron from a different library and note surname and firstname 3 - Login as the patron above 4 - Enter a new patron with the same surname and firstname 5 - See the 'Duplicate patron' warning 6 - Click to view the patron 7 - No info is listed 8 - Apply patch 9 - Reload and resubmit - or fill out form again 10 - Note that you see 'A patron from library XXX' and no popup link 11 - Add view_borrower_infos_from_any_libraries to the staff 12 - Repeat the duplication and confirm the warning now has patron name and the popup link is visible and works Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37562 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- This looks good! I agree with your reasoning on keeping the full search - changing that behavior now would likely be seen as a regression to a consortium whose data privacy rules are stricter than their card reciprocity rules. At this point it makes sense to remove that FIXME, since the commit message justifies keeping the existing behavior. For the rest, the patch works nicely and the QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37562 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37562 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37562 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.