http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8806&action=edit Bug 7887 - Add Option To Include Items That Will Be Available When Calculating Holds Ratios This commit adds the ability to include items that are on order in the aquisitions module, and items whose notforloan attribute is less than 1 ( i.e. will be available in the future ) when calculating holds ratios. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alex.arnaud@biblibre.com --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- This patch doesn't apply using 3-way merge. "CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/reserveratios.tt Failed to merge in the changes." -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8806|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11051&action=edit Bug 7887 - Add Option To Include Items That Will Be Available When Calculating Holds Ratios This commit adds the ability to include items that are on order in the aquisitions module, and items whose notforloan attribute is less than 1 ( i.e. will be available in the future ) when calculating holds ratios. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- 1. from patch: +my $not_for_loan_comparison = ( $include_will_be_available ) ? "<=" : "="; ... +notforloan $not_for_loan_comparison 0 AND damaged = 0 AND itemlost = 0 AND wthdrawn = 0 In which case notforloan will be lesser than 0? 2. As use of aqorders table is conditional, I think the join should be conditionnal too. 3. I get "Illegal division by zero at /home/julian/koha/versions/community-master/circ/reserveratios.pl line 155." when checking "Include on order items". It seems that x+NULL = NULL with MySQL. I think it can be fixed with (2) Failed QA for (3) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11576&action=edit Bug 7887 - Followup - Make use of aqorders conditional. Use COALESCE to prevent NULL addition. COALESCE is an ANSI-compliant SQL function, which returns the first non-null value passed to it. I have verified it is available in both MySQL and Postgres. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Small conflict, I think just textual -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11576|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14679&action=edit Bug 7887 - Followup - Make use of aqorders conditional. Use COALESCE to prevent NULL addition. COALESCE is an ANSI-compliant SQL function, which returns the first non-null value passed to it. I have verified it is available in both MySQL and Postgres. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Please add a test plan. -- You are receiving this mail because: You are watching all bug changes.