http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #5)
1. from patch: +my $not_for_loan_comparison = ( $include_will_be_available ) ? "<=" : "="; ... +notforloan $not_for_loan_comparison 0 AND damaged = 0 AND itemlost = 0 AND wthdrawn = 0
In which case notforloan will be lesser than 0?
Yes, a notforloan value of less than 0 indicates an item will eventually be available.
2. As use of aqorders table is conditional, I think the join should be conditionnal too.
3. I get "Illegal division by zero at /home/julian/koha/versions/community-master/circ/reserveratios.pl line 155." when checking "Include on order items". It seems that x+NULL = NULL with MySQL. I think it can be fixed with (2)
Failed QA for (3)
Will fix. -- You are receiving this mail because: You are watching all bug changes.