http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- There are circumstances where the fee is applied - if the item is already on loan (or otherwise unavailable) a hold fee will be applied immediately. If the item is available, no fee is applied, even at checkout. It might make more sense if a fee was applied immediately for items that are available, and only applied at checkout for any items that were unavailable when the hold was placed. This is true for 3.18.03.000, behaviour may differ at other versions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 lesley.speed@cheshireeast.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lesley.speed@cheshireeast.g | |ov.uk --- Comment #2 from lesley.speed@cheshireeast.gov.uk --- Is anyone doing any work on this as it is something we would really like fixing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What I understand: If it's the first hold placed on this record, the patron is not charged. See the following (ugly) snippet of code (from C4::Reserves::GetReserveFee): 794 if ( $allissued == 0 ) { 795 my $rsth = 796 $dbh->prepare("SELECT * FROM reserves WHERE biblionumber = ?"); 797 $rsth->execute($biblionumber); 798 if ( my $rdata = $rsth->fetchrow_hashref ) { 799 } 800 else { 801 $fee = 0; 802 } 803 } If no reserve exists, the fee is set to 0. This behavior seems to exist for a while. What would be the expected behavior? Does someone have an idea of why this condition exists? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I understand the bit about 'all out' versus 'at least one on the shelf' - but why only charge from the second hold onwards? Anyway, I tend to agree with Chris that we'd probably need a fix to be an option. What would make sense for me would be one of the following behaviours: - Charge for every hold placed - Charge for ever hold on pick-up (only filled holds) - Charge, if the library gets an available hold for you from the shelf (without the difference mentioned above between a first or later hold) Maybe we should ask about this on the mailing list to get a clear expectation on how this should work. We are also documenting this not very well right now - which explains why people think it's broken: 3.2 and 3.20 manual are both stating: If you charge patrons for placing holds on items, enter the fee amount in the 'Hold fee' field. Only enter numbers and decimals in this field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this could be something for the mailing lists - wonder if people are aware of current behaviour and if someone can explain "why". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please note that the sub has been refactored (without changing behavior but at least increasing readability) on bug 14702 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 sally.healey@cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshirewestan | |dchester.gov.uk --- Comment #10 from sally.healey@cheshirewestandchester.gov.uk --- (In reply to Joonas Kylmälä from comment #8)

(In reply to Katrin Fischer from comment #7)

...

I think this could be something for the mailing lists - wonder if people are aware of current behaviour and if someone can explain "why".

Now it is: https://lists.katipo.co.nz/pipermail/koha/2015-August/043527.html :)

This question was asked again: https://lists.katipo.co.nz/pipermail/koha/2015-November/044052.html We would be extremely keen to see a behaviour change, for the reasons outlined on the e-mail list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I am not sure the second option is needed - but the 1 and 3 would be good I think. Preserving the current behaviour and adding what I think is the more expected scenario. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #14 from Marc Véron <veron@veron.ch> --- There is a inconsitency in the name of the syspref - ReserveFee (in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref) - HoldFeeMode (in all other files) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #14)

There is a inconsitency in the name of the syspref

Sorry about that, last minute change :-/ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Sally Healey <sally.healey@cheshiresharedservices.gov.uk> --- Hold fee is applied if all items for the record are issued and at least one hold already exists on the record. This patch adds the ability to charge for any hold placed, regardless of the conditions. Test plan: 1) Execute the updatedb entry to insert the new pref 2) Confirm that the behavior is the same as before applying this patch 3) Change the HoldFeeMode pref to 'always' 4) Note that the fee is applied for any hold placed This patch has been tested and works as expected. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44838|0 |1 is obsolete| | --- Comment #19 from Sally Healey <sally.healey@cheshiresharedservices.gov.uk> --- Created attachment 45563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45563&action=edit Bug 13592: Add an option to charge for any hold placed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45563|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45863&action=edit [SIGNED-OFF] Bug 13592: Add an option to charge for any hold placed Currently the fee is applied on if all items for the record are issued and at least one hold already exists on the record. This patch does not give a complete answer to the problem (see discussion on bug 13592 for the other user's expectations). It only adds the ability to charge for any hold placed regardless of the conditions. Test plan: 1) Execute the updatedb entry to insert the new pref 2) Confirm that the behavior is the same as before applying this patch 3) Change the HoldFeeMode pref to 'always' 4) Note that the fee is applied for any hold placed Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45863|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45864&action=edit Bug 13592: Add an option to charge for any hold placed Currently the fee is applied on if all items for the record are issued and at least one hold already exists on the record. This patch does not give a complete answer to the problem (see discussion on bug 13592 for the other user's expectations). It only adds the ability to charge for any hold placed regardless of the conditions. Test plan: 1) Execute the updatedb entry to insert the new pref 2) Confirm that the behavior is the same as before applying this patch 3) Change the HoldFeeMode pref to 'always' 4) Note that the fee is applied for any hold placed Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.