http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 45205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45205&action=edit Bug 15225: Make HTML5Media work with file upload feature. Koha::Upload allows files to be attached to bibliographic records. HTML5Media streaming in Koha does not work with these files. Test plan: - apply patch - make sure OPACBaseURL is set correctly - enable HTML5MediaEnabled in OPAC and staff client - connect upload.pl to 856$u in your framework - upload a file with an extension set in HTML5MediaExtensions, make sure to set the codec correctly if you use WEBM (subfield c, eg. 'vp8, vorbis') - save record, view in staff client and browser, check if 'Play media' option is available and works -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Who signed the| |Hugo Agud patch off| | CC| |hagud@orex.es --- Comment #2 from Hugo Agud <hagud@orex.es> --- We have applied the patch and works fine at least with the files type webm and mp4 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 45725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45725&action=edit Bug 15225: [QA Follow-up] Improve changes to gethtml5media [1] Improve readability, add some checks. [2] Add the public flag for OPAC use. (If a file has not been marked as public, we should not return it in OPAC.) Test plan: See original commit. No changes in behavior. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Verified results with some additional debug lines. Somehow, showing the results in the browser was harder. This is not related to the changes on this report, but probably to the surrounding code. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 --- Comment #7 from Hugo Agud <hagud@orex.es> --- This is how we have tested, just step 7 is diffente In order to test the patch 0. Make sure that you have propertly added the video format in HTML5MediaExtensions 1 apply patch 2 make sure OPACBaseURL is set correctly 3 enable HTML5MediaEnabled in OPAC and staff client 4 connect upload.pl to 856$u in your framework 5. connect upload.pl to 856$u in your framework 6. upload a file with an extension set in HTML5MediaExtensions 7. Configure 856$q (video/webm or video/mp4) 8. SAve record, view in staff client and browser, check if 'PLay media' option is available and works -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45725|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 45976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45976&action=edit Bug 15225: [QA Follow-up] Improve changes to gethtml5media [1] Improve readability, add some checks. [2] Add the public flag for OPAC use. (If a file has not been marked as public, we should not return it in OPAC.) Test plan: See original commit. No changes in behavior. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45976|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 45977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45977&action=edit Bug 15225: [QA Follow-up] Improve changes to gethtml5media [1] Improve readability, add some checks. [2] Add the public flag for OPAC use. (If a file has not been marked as public, we should not return it in OPAC.) Test plan: See original commit. No changes in behavior. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Mirko and Marcel! -- You are receiving this mail because: You are watching all bug changes.