http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23297|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 35482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35482&action=edit Bug 11337: Remove the C4::Serials::GetSubscriptions routine Since SearchSubscriptions is the way to search subscriptions, each call to GetSubscriptions could be replaced by a call to SearchSubscriptions. Test plan: Verify following pages display the same thing as before this patch: - catalogue/detail.pl - opac/opac-ISBDdetail.pl - opac/opac-detail.pl Verify the following page returns correct results: - serials/checkexpiration.pl Verify the Serials UT file still passes: - prove t/db_dependent/Serials.t Note: The title filter on checkexpiration now only searches on the title DB field. I don't think it is a regression, it should be the way to use this field. Maybe should we add new search fields on this form. Bug 5337 reintroduces a bug fixed by bug 5864, this patch restore the right way to search subscription (based on biblionumber). Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35482|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35514&action=edit [PASSED QA] Bug 11337: Remove the C4::Serials::GetSubscriptions routine Since SearchSubscriptions is the way to search subscriptions, each call to GetSubscriptions could be replaced by a call to SearchSubscriptions. Test plan: Verify following pages display the same thing as before this patch: - catalogue/detail.pl - opac/opac-ISBDdetail.pl - opac/opac-detail.pl Verify the following page returns correct results: - serials/checkexpiration.pl Verify the Serials UT file still passes: - prove t/db_dependent/Serials.t Note: The title filter on checkexpiration now only searches on the title DB field. I don't think it is a regression, it should be the way to use this field. Maybe should we add new search fields on this form. Bug 5337 reintroduces a bug fixed by bug 5864, this patch restore the right way to search subscription (based on biblionumber). Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- The last patch fixes a trivial conflict on the test file. -- You are receiving this mail because: You are watching all bug changes.