[Bug 13879] New: DataTables server-side processing for patrons - sort is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Bug ID: 13879 Summary: DataTables server-side processing for patrons - sort is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 13021 introduced a regression for guarantor search and patron search for orders, the sort is broken. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13021 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37040&action=edit Bug 13879: Fix sort on patron search (guarantor and linked to orders) This patch fixes a regression introduced by bug 13021. Test plan: 1/ Go on a child detail page > edit 2/ Click on "Set a patron" as a guarantor 3/ Launch a search a confirm that you are able to sort on card, name and date of birth. Note that the Address column is not sortable (it's a limitation, could be fixed later). 4/ Go on the acquisition module, create an order. 5/ Click on the "Add user" button. 6/ Launch a search a confirm that you are able to sort on card, name and category -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 37059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37059&action=edit [Signed-off] Bug 13879: Fix sort on patron search (guarantor and linked to orders) This patch fixes a regression introduced by bug 13021. Test plan: 1/ Go on a child detail page > edit 2/ Click on "Set a patron" as a guarantor 3/ Launch a search a confirm that you are able to sort on card, name and date of birth. Note that the Address column is not sortable (it's a limitation, could be fixed later). 4/ Go on the acquisition module, create an order. 5/ Click on the "Add user" button. 6/ Launch a search a confirm that you are able to sort on card, name and category Without patch, I could not sort on names. With patch, sorting works as dexcribed in Test plan Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37040|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37059|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37072&action=edit [PASSED QA] Bug 13879: Fix sort on patron search (guarantor and linked to orders) This patch fixes a regression introduced by bug 13021. Test plan: 1/ Go on a child detail page > edit 2/ Click on "Set a patron" as a guarantor 3/ Launch a search a confirm that you are able to sort on card, name and date of birth. Note that the Address column is not sortable (it's a limitation, could be fixed later). 4/ Go on the acquisition module, create an order. 5/ Click on the "Add user" button. 6/ Launch a search a confirm that you are able to sort on card, name and category Without patch, I could not sort on names. With patch, sorting works as dexcribed in Test plan Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13891 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Forgot to mark as pushed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org