[Bug 37398] New: Date Field changes from mm/dd/yyyy to 0000-00-00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Bug ID: 37398 Summary: Date Field changes from mm/dd/yyyy to 0000-00-00 Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: eric@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl A typed in value that follows the dateFormat system preference (mm/dd/yyyy) is changed to 0000-00-00 when the item is saved. This was found in 952$w before enabling the dateaccessioned.pl plugin for the subfield. To recreate: -set system preference dateFormat to mm/dd/yyyy -Go to an existing bib record -Edit items -input a date following the specified format (07-17-2024) -save the item -check the item and notice the date has been changed to 0000-00-00 -click back to the bib record -Error 500: Internal server error - Month out of range -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Without the dateaccessioned.pl, you had no datepicker widget, right? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- I can't reproduce this in main. I did the following in k-t-d: 1. Remove the dateaccessioned.pl plugin for the 952$w in the framework I am using. 2. Add/edit item and enter a date in the 'w - Price effective from' in the format specified in my dateFormat system preference. I get: Invalid value passed, items.replacementpricedate=07/17/2024 expected type is date at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #3 from Eric <eric@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #1)
Without the dateaccessioned.pl, you had no datepicker widget, right?
Correct. It was just an empty input box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Date Field changes from |Date fields in items change |mm/dd/yyyy to 0000-00-00 |to invalid date on save, | |when dateaccessioned.pl is | |not used -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Recreated on main - you need to disable 'strict_sql_modes' in the koha-conf - then it happens as described -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens (kidclamp) from comment #4)
Recreated on main - you need to disable 'strict_sql_modes' in the koha-conf - then it happens as described
That's interesting. But doesn't that break a lot of other things like circulation reports too? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I think what we should do is: - Make a list of all 'date' fields in the items table - If a subfield in the items form is mapped to one of the fields above then we use a datepicker explicitly - whether or not plugin is enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5)
(In reply to Nick Clemens (kidclamp) from comment #4)
Recreated on main - you need to disable 'strict_sql_modes' in the koha-conf - then it happens as described
That's interesting. But doesn't that break a lot of other things like circulation reports too?
Disabling strict mode? I don't think so - enabling it makes things stricter - it's on by default in KTD so we don't break the rules further - but I don't believe most run it in production, we don't -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I read it the wrong way around. I thought you said "make it stricter". So things here break if you make things less strict. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- My opinion, for what it is worth, is that the dateaccessioned.pl plugin should be automatically set on date and datetime fields with no ability to remove via frameworks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #9)
My opinion, for what it is worth, is that the dateaccessioned.pl plugin should be automatically set on date and datetime fields with no ability to remove via frameworks.
Just a suggestion: can we rename it, if we do that? Otherwise we will probably be stuck forever. I also thought we already had it added to other fields as well. Does it more than just adding the date widget? Because than we might just do that without a plugin? What about timestamp? The time part might pose a problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
(In reply to Lucas Gass from comment #9)
My opinion, for what it is worth, is that the dateaccessioned.pl plugin should be automatically set on date and datetime fields with no ability to remove via frameworks.
Just a suggestion: can we rename it, if we do that? Otherwise we will probably be stuck forever. I also thought we already had it added to other fields as well.
Does it more than just adding the date widget? Because than we might just do that without a plugin?
What about timestamp? The time part might pose a problem?
The other thing it does is set_to_today when you click on field. We can deal with date and datetime, I think. We already do this in other places with Flatpickr/Maskito. I think renaming the plugin is a good idea. The last question I have is, should it continue to be a plugin? Or should we just make it not a plugin? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think if you save empty, it also saves today's date. But we might need to verify if that is enough. I am open to it being not a plugin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171416&action=edit Bug 37398: Make date and date time fields have date picker by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171417&action=edit Bug 37398: Adjust CSS for wrapped flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171419&action=edit Bug 37398: Make sure subfield and subfield_date are defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171420&action=edit Bug 37398: Add a unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171416|0 |1 is obsolete| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171421&action=edit Bug 37398: Make date and date time fields have date picker by default To test: 1. APPLY PATCH, restart_all 2. Pick a framework, I choose BKS in k-t-d 3. Make sure that a few date and datetime fields are exposed in the editor. 4. On additem.tt a date picker should be instantiated on the date or datetime fields. 5. Make sure the date pickers work on each field. 6. If it is a datetime field you should have the option to add hours and minutes. ( datelastseen ) 7. Edit the framework and remove the dateaccessioned.pl plugin from any of these date fields. 8. Even without the dateaccessioned.pl plugin a date picker should be present on the field. 9. Add the dateaccessioned.pl plugin to a non date/datetime field. 10. Make sure the dateaccessioned.pl plugin works properly on the non date/datetime field. 11. Mark one of the date/datetime fields as mandatory, make sure it still acts as mandatory. 12. Hide date/datetime from the editor, make sure it hides properly. +----------------------+-------------+ | COLUMN_NAME | COLUMN_TYPE | +----------------------+-------------+ | dateaccessioned | date | | replacementpricedate | date | | datelastborrowed | date | | datelastseen | datetime | | onloan | date | +----------------------+-------------+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171417|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171422&action=edit Bug 37398: Adjust CSS for wrapped flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171419|0 |1 is obsolete| | --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171423&action=edit Bug 37398: Make sure subfield and subfield_date are defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171420|0 |1 is obsolete| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171424&action=edit Bug 37398: Add a unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #21 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 27768 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Phil Ringnalda <phil@chetcolibrary.org> --- Snag that becomes very visible at step 11: Without the patch, a subfield using dateaccessioned.pl has a "..." at the end of the input, clicking it fills in Today without opening Flatpickr, and if the subfield is mandatory, the "..." pushes the "Required" label over to the right. With the patch, the "..." is replaced by a big red "X" to clear the field, which overlaps the Required label instead of pushing it over to the right, making it visually a sort of "℞equired" only with more X I'm guessing, without being sure, that it's an acceptable keyboard accessibility change that instead of actively changing the date to today by tabbing past Flatpickr (not thinking about what a screenreader does as it opens) to the "..." and hitting enter, you instead tab past it to something labelled "Clear date" and hit enter on it, trusting that it will become today when you save with it empty? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171881&action=edit Bug 37398: Add set to today function to calendar.inc To test: 1. Try editing some items with a empty value in the flatpickr. 2. Make sure the empty date fields get a date set to today when you click on the empty field. 3. Try a datetime field, making sure the datetime is correctly set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171882&action=edit Bug 37398: Adjust CSS for flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171919&action=edit Bug 37398: Do not rely on the columns names but data type instead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- + if ($subfield->{kohafield} =~ /items\.(replacementpricedate|dateaccessioned|datelastborrowed|onloan)/) { + $subfield_data{datetype} = 'date'; + } + + if ($subfield->{kohafield} =~ /items\.(datelastseen|damaged_on|itemlost_on|withdrawn_on|deleted_on)/) { + $subfield_data{datetype} = 'datetime'; + } I think I would much prefer to see something generic that this list of fields. See the last patch, for discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #26)
+ if ($subfield->{kohafield} =~ /items\.(replacementpricedate|dateaccessioned|datelastborrowed|onloan)/) { + $subfield_data{datetype} = 'date'; + } + + if ($subfield->{kohafield} =~ /items\.(datelastseen|damaged_on|itemlost_on|withdrawn_on|deleted_on)/) { + $subfield_data{datetype} = 'datetime'; + }
I think I would much prefer to see something generic that this list of fields.
See the last patch, for discussion.
This had crossed my mind. I agree with the change, Jonathan. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Date fields in items change |Initialize a datepicker on |to invalid date on save, |all date/datetime fields |when dateaccessioned.pl is |when adding/editing items |not used | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38001 [Bug 38001] Remove dateaccessioned.pl plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #28 from Phil Ringnalda <phil@chetcolibrary.org> --- Either need a different unit test, or none, then. That breaks attachment 171424 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171963&action=edit Bug 37398: Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Phil Ringnalda <phil@chetcolibrary.org> --- Test plan now fails at 6. If it is a datetime field you should have the option to add hours and minutes. ( datelastseen ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #31 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #30)
Test plan now fails at
6. If it is a datetime field you should have the option to add hours and minutes. ( datelastseen )
What item field and framework are you testing? This works for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #32 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucas Gass from comment #31)
(In reply to Phil Ringnalda from comment #30)
Test plan now fails at
6. If it is a datetime field you should have the option to add hours and minutes. ( datelastseen )
What item field and framework are you testing? This works for me.
The only item field to really test this on is datelastseen. I do get a flatpickr with the data-flatpickr-enable-time attribute. I am going to reset this to 'Needs sign-off' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #33 from Phil Ringnalda <phil@chetcolibrary.org> --- Oh, that's what I was doing, still looking at the keyboard user wanting to set things to today without having the former plugin-provided "..." Steps to reproduce failure: 1. Set 952$r to be visible in Editor 2. Edit an item, existing or new 3. Click the red X to clear the value from 952$r 4. Click in the input for 952$r You now have a date picker, not a datetime picker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #34 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #33)
Oh, that's what I was doing, still looking at the keyboard user wanting to set things to today without having the former plugin-provided "..."
Steps to reproduce failure: 1. Set 952$r to be visible in Editor 2. Edit an item, existing or new 3. Click the red X to clear the value from 952$r 4. Click in the input for 952$r
You now have a date picker, not a datetime picker.
OK, I see what you mean now. Thanks for clarifying. Feel free to set back to FQA, I'll follow-up asap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #35 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #33)
Oh, that's what I was doing, still looking at the keyboard user wanting to set things to today without having the former plugin-provided "..."
Steps to reproduce failure: 1. Set 952$r to be visible in Editor 2. Edit an item, existing or new 3. Click the red X to clear the value from 952$r 4. Click in the input for 952$r
You now have a date picker, not a datetime picker.
After testing I notice this is happening on all datetime pickers, with or without this patch. I filed this separately: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38027 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38027 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38027 [Bug 38027] Clearing a flatpickr datetime causes errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #36 from Phil Ringnalda <phil@chetcolibrary.org> --- I'm very carefully not noticing that saving an item with a blank datelastseen sets it to the current time in the database's timezone, and clicking in a blank datelastseeen field to trigger flatpickr and saving sets it to the current time in the browser's timezone, because if I notice timezone conversion failures I have to go outside and wander around until I forget what I saw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #37 from Phil Ringnalda <phil@chetcolibrary.org> --- The CSS change for .item_edit_form span.required needs to also apply to .item_edit_form span.important -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #38 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172187&action=edit Bug 37398: Add CSS for the important class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171421|0 |1 is obsolete| | --- Comment #39 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172188&action=edit Bug 37398: Make date and date time fields have date picker by default To test: 1. APPLY PATCH, restart_all 2. Pick a framework, I choose BKS in k-t-d 3. Make sure that a few date and datetime fields are exposed in the editor. 4. On additem.tt a date picker should be instantiated on the date or datetime fields. 5. Make sure the date pickers work on each field. 6. If it is a datetime field you should have the option to add hours and minutes. ( datelastseen ) 7. Edit the framework and remove the dateaccessioned.pl plugin from any of these date fields. 8. Even without the dateaccessioned.pl plugin a date picker should be present on the field. 9. Add the dateaccessioned.pl plugin to a non date/datetime field. 10. Make sure the dateaccessioned.pl plugin works properly on the non date/datetime field. 11. Mark one of the date/datetime fields as mandatory, make sure it still acts as mandatory. 12. Hide date/datetime from the editor, make sure it hides properly. +----------------------+-------------+ | COLUMN_NAME | COLUMN_TYPE | +----------------------+-------------+ | dateaccessioned | date | | replacementpricedate | date | | datelastborrowed | date | | datelastseen | datetime | | onloan | date | +----------------------+-------------+ Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171422|0 |1 is obsolete| | --- Comment #40 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172189&action=edit Bug 37398: Adjust CSS for wrapped flatpickr Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171423|0 |1 is obsolete| | --- Comment #41 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172190&action=edit Bug 37398: Make sure subfield and subfield_date are defined Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171424|0 |1 is obsolete| | --- Comment #42 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172191&action=edit Bug 37398: Add a unit test Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171881|0 |1 is obsolete| | --- Comment #43 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172192&action=edit Bug 37398: Add set to today function to calendar.inc To test: 1. Try editing some items with a empty value in the flatpickr. 2. Make sure the empty date fields get a date set to today when you click on the empty field. 3. Try a datetime field, making sure the datetime is correctly set. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171882|0 |1 is obsolete| | --- Comment #44 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172193&action=edit Bug 37398: Adjust CSS for flatpickr Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171919|0 |1 is obsolete| | --- Comment #45 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172194&action=edit Bug 37398: Do not rely on the columns names but data type instead Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171963|0 |1 is obsolete| | --- Comment #46 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172195&action=edit Bug 37398: Adjust tests Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172187|0 |1 is obsolete| | --- Comment #47 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172196&action=edit Bug 37398: Add CSS for the important class Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172188|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174558&action=edit Bug 37398: Make date and date time fields have date picker by default To test: 1. APPLY PATCH, restart_all 2. Pick a framework, I choose BKS in k-t-d 3. Make sure that a few date and datetime fields are exposed in the editor. 4. On additem.tt a date picker should be instantiated on the date or datetime fields. 5. Make sure the date pickers work on each field. 6. If it is a datetime field you should have the option to add hours and minutes. ( datelastseen ) 7. Edit the framework and remove the dateaccessioned.pl plugin from any of these date fields. 8. Even without the dateaccessioned.pl plugin a date picker should be present on the field. 9. Add the dateaccessioned.pl plugin to a non date/datetime field. 10. Make sure the dateaccessioned.pl plugin works properly on the non date/datetime field. 11. Mark one of the date/datetime fields as mandatory, make sure it still acts as mandatory. 12. Hide date/datetime from the editor, make sure it hides properly. +----------------------+-------------+ | COLUMN_NAME | COLUMN_TYPE | +----------------------+-------------+ | dateaccessioned | date | | replacementpricedate | date | | datelastborrowed | date | | datelastseen | datetime | | onloan | date | +----------------------+-------------+ Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172189|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174559&action=edit Bug 37398: Adjust CSS for wrapped flatpickr Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172190|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174560&action=edit Bug 37398: Make sure subfield and subfield_date are defined Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172191|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174561&action=edit Bug 37398: Add a unit test Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172192|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174562&action=edit Bug 37398: Add set to today function to calendar.inc To test: 1. Try editing some items with a empty value in the flatpickr. 2. Make sure the empty date fields get a date set to today when you click on the empty field. 3. Try a datetime field, making sure the datetime is correctly set. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172193|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174563&action=edit Bug 37398: Adjust CSS for flatpickr Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172194|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174564&action=edit Bug 37398: Do not rely on the columns names but data type instead Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172195|0 |1 is obsolete| | --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174565&action=edit Bug 37398: Adjust tests Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172196|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174566&action=edit Bug 37398: Add CSS for the important class Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Great job, few remarks. WARN Koha/UI/Form/Builder/Item.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 144, now: 154) WARN t/db_dependent/Koha/UI/Form/Builder/Item.t WARN tidiness The file is less tidy than before (bad/messy lines before: 116, now: 127) Ignoring the spaces here. + my $columns = Koha::Items->_resultset->result_source->columns_info; + $subfield_data{data_type} = + defined $subfield->{kohafield} ? $columns->{ $subfield->{kohafield} =~ s|^items\.||r }->{data_type} : undef; Actually, is it possible to have an item subfield without a kohafield ? (No blocker) Seems that the r modifier was added in Perl 5.14. So that looks okay to me. Felt new, but wasnt. Feels like an enh btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Feels like an enh btw.
I agree, will keep this for 25.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #57)
+ my $columns = Koha::Items->_resultset->result_source->columns_info; + $subfield_data{data_type} = + defined $subfield->{kohafield} ? $columns->{ $subfield->{kohafield} =~ s|^items\.||r }->{data_type} : undef; Actually, is it possible to have an item subfield without a kohafield ? (No blocker)
Yes, if you leave kohafield empty/NULL, then Koha will store the information in more_subfields_xml. It allows to add extra fields where we don't have a database column. But then they cannot be of the type date at the same time... right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this might have broken t/db_dependent/selenium/basic_workflow.t: Error while executing command: no such element: Unable to locate element: //div[@id="subfield952w"]/input[@type="text" and @class="input_marceditor items.replacementpricedate noEnterSubmit flatpickr-input"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. Please check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #61)
I believe this might have broken t/db_dependent/selenium/basic_workflow.t:
Error while executing command: no such element: Unable to locate element: //div[@id="subfield952w"]/input[@type="text" and @class="input_marceditor items.replacementpricedate noEnterSubmit flatpickr-input"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.
Please check.
Since replacementpricedate cannot have the flatpickr unset now I think we can assume a prefilled date with %Y-%m-%d already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176020&action=edit Bug 37398: Fix test in basic_workflow.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up "Fix test in basic_workflow.t" picked up for main, thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #65 from Alex Buckley <alexbuckley@catalyst.net.nz> --- *** Bug 30931 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement adds the release notes| |date picker by default to | |all item date and datetime | |fields. --- Comment #66 from David Nind <david@davidnind.com> --- I've attempted a release note. Are there any nuances/changes in behavour that libraries should be aware of? Please amend as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Bug 37398 depends on bug 38027, which changed state. Bug 38027 Summary: Clearing a flatpickr datetime causes errors https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38027 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #67 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Could we please get this backported to 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 --- Comment #68 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #69 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39811 [Bug 39811] Restore date replacement functionality lost in Bug 37398 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org