https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37398 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Great job, few remarks. WARN Koha/UI/Form/Builder/Item.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 144, now: 154) WARN t/db_dependent/Koha/UI/Form/Builder/Item.t WARN tidiness The file is less tidy than before (bad/messy lines before: 116, now: 127) Ignoring the spaces here. + my $columns = Koha::Items->_resultset->result_source->columns_info; + $subfield_data{data_type} = + defined $subfield->{kohafield} ? $columns->{ $subfield->{kohafield} =~ s|^items\.||r }->{data_type} : undef; Actually, is it possible to have an item subfield without a kohafield ? (No blocker) Seems that the r modifier was added in Perl 5.14. So that looks okay to me. Felt new, but wasnt. Feels like an enh btw. -- You are receiving this mail because: You are watching all bug changes.