[Bug 25987] New: Radio buttons are misaligned in New label batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Bug ID: 25987 Summary: Radio buttons are misaligned in New label batches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When you go in Tools > Label creator > New > Label batch, the Enter by barcode and Enter by itemnumber radio buttons are misaligned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106880&action=edit Bug 25987: Fix alignment of fields in label batch creation form This patch makes minor markup changes to the template for the label batch creation process so that form fields line up correctly. Unrelated change: A hint has been moved out of the label area to below the textarea in order to conform with established patterns. To test, apply the patch and go to Tools > Label creator > New > Label batch. - In the batch creation form the "Enter by itemnumber" and "Enter by barcode" should be aligned correctly with each other. - The "One number per line..." hint should appear below the textarea. - Test that the form fields are still correctly aligned after adding some items to the batch and the "description" field is shown in the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106880|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 106881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106881&action=edit Bug 25987: Fix alignment of fields in label batch creation form This patch makes minor markup changes to the template for the label batch creation process so that form fields line up correctly. Unrelated change: A hint has been moved out of the label area to below the textarea in order to conform with established patterns. To test, apply the patch and go to Tools > Label creator > New > Label batch. - In the batch creation form the "Enter by itemnumber" and "Enter by barcode" should be aligned correctly with each other. - The "One number per line..." hint should appear below the textarea. - Test that the form fields are still correctly aligned after adding some items to the batch and the "description" field is shown in the form. Works for me! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106881|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106888&action=edit Bug 25987: Fix alignment of fields in label batch creation form This patch makes minor markup changes to the template for the label batch creation process so that form fields line up correctly. Unrelated change: A hint has been moved out of the label area to below the textarea in order to conform with established patterns. To test, apply the patch and go to Tools > Label creator > New > Label batch. - In the batch creation form the "Enter by itemnumber" and "Enter by barcode" should be aligned correctly with each other. - The "One number per line..." hint should appear below the textarea. - Test that the form fields are still correctly aligned after adding some items to the batch and the "description" field is shown in the form. Works for me! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25987 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- minor aesthetic enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org