[Bug 25147] New: AllowSelfCheckReturns is in the wrong system preference section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Bug ID: 25147 Summary: AllowSelfCheckReturns is in the wrong system preference section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Unless I misunderstand the purpose of the AllowSelfCheckReturns system preference, I think it should be in the "Self check-in module" section of the Circulation system preferences. It is currently in the "Self Checkout" section. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 103022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103022&action=edit Bug 25147: AllowSelfCheckReturns is in the wrong system preference section This patch moves the AllowSelfCheckReturns system preference to the "Self check-in module" section of the Circulation system preferences. To test: 1) Check that the AllowSelfCheckReturns system preference is currently in the "Self Checkout" section of the Circulation system preferences. 2) Apply the patch 3) The preference should now be in the "Self check-in module" section of the Circulation system preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103022|0 |1 is obsolete| | --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 103059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103059&action=edit Bug 25147: AllowSelfCheckReturns is in the wrong system preference section This patch moves the AllowSelfCheckReturns system preference to the "Self check-in module" section of the Circulation system preferences. To test: 1) Check that the AllowSelfCheckReturns system preference is currently in the "Self Checkout" section of the Circulation system preferences. 2) Apply the patch 3) The preference should now be in the "Self check-in module" section of the Circulation system preferences. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103059|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103069&action=edit Bug 25147: AllowSelfCheckReturns is in the wrong system preference section This patch moves the AllowSelfCheckReturns system preference to the "Self check-in module" section of the Circulation system preferences. To test: 1) Check that the AllowSelfCheckReturns system preference is currently in the "Self Checkout" section of the Circulation system preferences. 2) Apply the patch 3) The preference should now be in the "Self check-in module" section of the Circulation system preferences. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Everything currently in the chunk labelled "Self Checkout" is preferences used to control sco-main.pl, a feature that does checkout and renewal, and optionally with the preference AllSelfCheckReturns, also checkin. Everything currently in the chunk labelled "Self check-in module" is preferences used to control sci-main.pl, a separate feature that does only checkin, and does checkin whether or not AllowSelfCheckReturns is set. I'd think a better solution would be to either rename the preference, which is actually AllowReturnsInSelfCheckout, or rename the chunks to make it more clear that they are preferences for two different features. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Phil Ringnalda from comment #4)
Everything currently in the chunk labelled "Self Checkout" is preferences used to control sco-main.pl, a feature that does checkout and renewal, and optionally with the preference AllSelfCheckReturns, also checkin.
Everything currently in the chunk labelled "Self check-in module" is preferences used to control sci-main.pl, a separate feature that does only checkin, and does checkin whether or not AllowSelfCheckReturns is set.
I'd think a better solution would be to either rename the preference, which is actually AllowReturnsInSelfCheckout, or rename the chunks to make it more clear that they are preferences for two different features
Fair comment, I'd accept a followup to clarify the situation further. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- On further consideration, I'm going to revert this patch from master and replace it with a quick followup to clarify the preference name as suggested by Phil. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103116&action=edit Bug 25147: Rename preference This patch renames the preference from the ambiguous 'AllowSelfCheckReturns' to 'SCOAllowCheckin' which is more consistent with other preferences affecting this module. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103117&action=edit Bug 25147: Clarify section name Clarify the preference section headings for Self-checkout and Self-checkin. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Alternatives pushed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103120&action=edit Bug 25147: (RM follow-up) Update display I missed the display change in the preference name change.. oops. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103121&action=edit Bug 25147: (RM follow-up) Update pref references. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I made a right hash of that.. should all be good now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25147 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26131 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 [Bug 26131] console errors when attempting to open SCO related system preferences -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org